From: Sverre Rabbelier <srabbelier@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Stephen Haberman <stephen@exigencecorp.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Thomas Rast <trast@student.ethz.ch>,
Git Mailing List <git@vger.kernel.org>,
Stephan Beyer <s-beyer@gmx.net>,
Christian Couder <chriscool@tuxfamily.org>,
Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [RFH] rebase -i optimization
Date: Fri, 27 Feb 2009 13:29:32 +0100 [thread overview]
Message-ID: <fabb9a1e0902270429t5d31aaaet1e8c07e2b42751c3@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0902271146460.6600@intel-tinevez-2-302>
Heya,
On Fri, Feb 27, 2009 at 11:50, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> On one hand, I could imagine that it is just a question of skipping those
> 'pick' commands that do not contribute anything. That would be a pretty
> simple function that would be called at the very beginning.
Exactly, that's what I had in mind.
> On the other hand, this very simple strategy would fail pretty quickly
> (and badly) with -i -p. And that is the stuff I am mostly spending my Git
> time budget on these days.
I would be fine with making this optimization optional (with a config
option?), and barf if both the optimization and -p are supplied. We
could even automagically ignore the config option for -p, and only
barf if both -p and this option are specified explicitly?
> Having said that, I think yours might be such a common case that it is
> worth optimizing for.
Does this fit in your git time budget, or would you prefer I have a
stab at it? If the latter, any hints on where to put such a call?
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2009-02-27 12:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 14:55 [RFH] rebase -i optimization Sverre Rabbelier
2009-02-26 14:59 ` Johannes Schindelin
2009-02-26 15:33 ` Sverre Rabbelier
2009-02-27 10:50 ` Johannes Schindelin
2009-02-27 12:29 ` Sverre Rabbelier [this message]
2009-02-27 12:56 ` [PATCH] rebase -i: avoid 'git reset' when possible Johannes Schindelin
2009-02-27 13:03 ` Sverre Rabbelier
2009-02-27 13:33 ` Johannes Schindelin
2009-03-01 8:38 ` Junio C Hamano
2009-03-01 21:57 ` Johannes Schindelin
2009-03-03 0:57 ` Junio C Hamano
2009-03-03 9:24 ` Johannes Schindelin
2009-03-03 9:55 ` [PATCH v2] " Johannes Schindelin
2009-03-03 11:19 ` Johannes Sixt
2009-03-03 11:21 ` Johannes Schindelin
2009-02-27 1:10 ` [RFH] rebase -i optimization Sitaram Chamarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e0902270429t5d31aaaet1e8c07e2b42751c3@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=s-beyer@gmx.net \
--cc=spearce@spearce.org \
--cc=stephen@exigencecorp.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).