From: Sverre Rabbelier <srabbelier@gmail.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, John Tapsell <johnflux@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 01/10] refs: add "for_each_bisect_ref" function
Date: Thu, 26 Mar 2009 13:37:14 +0100 [thread overview]
Message-ID: <fabb9a1e0903260537r61647d82t4ffb6b8b67d5c2f1@mail.gmail.com> (raw)
In-Reply-To: <200903260848.42104.chriscool@tuxfamily.org>
Heya,
On Thu, Mar 26, 2009 at 08:48, Christian Couder <chriscool@tuxfamily.org> wrote:
> I am not a big fan of cover letters. Usually I prefer adding comments in the
> patches.
The downside of that is that it makes it harder to quickly scan the
series; now I have to go through each patch (which involves trying
finding which patch is next, as my MUA is retarded and doesn't
understand proper threading).
>> And no description of the
>> individual patches either!
>
> There is a commit message in each patch. And many of the patches are very
> small.
Hehe, my bad; the first one didn't have a commit message, which is the
one I looked at first.
> If some commit messages are not clear enough, please tell me and I will try
> to improve them ;)
The rest of the series is nicely readable, I guess I shouldn't send
whine mails before reading the entire series next time :).
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2009-03-26 12:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 4:55 [PATCH 01/10] refs: add "for_each_bisect_ref" function Christian Couder
2009-03-26 6:20 ` Sverre Rabbelier
2009-03-26 7:48 ` Christian Couder
2009-03-26 12:37 ` Sverre Rabbelier [this message]
2009-03-26 15:50 ` Michael J Gruber
2009-03-26 16:52 ` Johannes Schindelin
2009-03-26 16:54 ` Sverre Rabbelier
2009-03-27 0:41 ` Christian Couder
2009-03-27 1:32 ` sending patch sets (was: Re: [PATCH 01/10] refs: add "for_each_bisect_ref" function) Julian Phillips
2009-03-27 7:22 ` Christian Couder
2009-03-27 2:08 ` [PATCH 01/10] refs: add "for_each_bisect_ref" function Johannes Schindelin
2009-03-27 7:21 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e0903260537r61647d82t4ffb6b8b67d5c2f1@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johnflux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).