From: Sverre Rabbelier <srabbelier@gmail.com>
To: Josh Micich <josh.micich@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] added --batch option to mktree
Date: Thu, 14 May 2009 12:25:41 +0200 [thread overview]
Message-ID: <fabb9a1e0905140325g2f376cf1lcaf206278a942c47@mail.gmail.com> (raw)
In-Reply-To: <a644352c0905140224g41f645c1l734bee791656ea1d@mail.gmail.com>
Heya,
On Thu, May 14, 2009 at 11:24, Josh Micich <josh.micich@gmail.com> wrote:
> If you find this logic persuasive, I can fix all the other issues and
> re-submit this patch.
I suspect Junio's point was more in the gist of "you should explain
this in your commit message". So if you do resend your patch, include
the above explanation (or at least the mention of the 30% speedup) in
your commit message.
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2009-05-14 10:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 5:06 Proposed patch for mktree [0/3] Josh Micich
2009-05-14 5:09 ` [PATCH 1/3] '--missing' option for mktree: re-added strbuf_release(&p_uq), Updated man page Josh Micich
2009-05-14 6:04 ` Junio C Hamano
2009-05-14 19:44 ` Josh Micich
2009-05-14 5:10 ` [PATCH 2/3] added --batch option to mktree Josh Micich
2009-05-14 6:18 ` Junio C Hamano
2009-05-14 9:24 ` Josh Micich
2009-05-14 10:25 ` Sverre Rabbelier [this message]
2009-05-14 19:51 ` Josh Micich
[not found] ` <a644352c0905140217h382a4d18h988b229c12577de3@mail.gmail.com>
2009-05-15 8:31 ` Junio C Hamano
2009-05-14 5:11 ` [PATCH 3/3] improved validation of entry type in mktree Josh Micich
2009-05-14 6:24 ` Junio C Hamano
2009-05-14 22:46 ` Josh Micich
2009-05-14 22:49 ` Josh Micich
2009-05-15 6:23 ` Jakub Narebski
2009-05-15 16:57 ` Josh Micich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e0905140325g2f376cf1lcaf206278a942c47@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=git@vger.kernel.org \
--cc=josh.micich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).