From: Sverre Rabbelier <srabbelier@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git List <git@vger.kernel.org>,
Ian Clatworthy <ian.clatworthy@canonical.com>,
Matt McClure <mlm@aya.yale.edu>,
Miklos Vajna <vmiklos@frugalware.org>,
Julian Phillips <julian@quantumfyre.co.uk>,
vcs-fast-import-devs@lists.launchpad.net
Subject: Re: [PATCH v7 3/6] fast-import: add feature command
Date: Sat, 12 Sep 2009 21:43:41 +0200 [thread overview]
Message-ID: <fabb9a1e0909121243l240dcb68jbd0207bd4b21d4ca@mail.gmail.com> (raw)
In-Reply-To: <20090912185122.GQ1033@spearce.org>
Heya,
On Sat, Sep 12, 2009 at 20:51, Shawn O. Pearce <spearce@spearce.org> wrote:
> Where is the documentation for 'feature date-format=<FORMAT>'?
D'oh, I forgot, my bad.
> Also, IIRC the fast-import list agreed that the <feature> name must
> match the re ^[a-zA-Z][a-zA-Z-]*$.
Ah, yes, of course, I'll update that.
> Saying that here does somewhat
> help another fast-import developer to use the same stream format,
> but it does not help a user to understand what features they can
> ask for in their stream.
No, you're absolutely right, there should be a section on supported features.
> So its legal to change the data format in the middle of a stream?
I'll add a !seen_non_option_command check to parse_feature, perhaps
renaming it to 'seen_data_command'?
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2009-09-12 19:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-06 14:35 [PATCH v7 0/6] fast-import: add new feature and option command Sverre Rabbelier
2009-09-06 14:35 ` [PATCH v7 1/6] fast-import: put option parsing code in separate functions Sverre Rabbelier
2009-09-06 14:35 ` [PATCH v7 2/6] fast-import: put marks reading in it's own function Sverre Rabbelier
2009-09-06 14:35 ` [PATCH v7 3/6] fast-import: add feature command Sverre Rabbelier
2009-09-06 14:35 ` [PATCH v7 4/6] fast-import: test the new " Sverre Rabbelier
2009-09-06 14:35 ` [PATCH v7 5/6] fast-import: add option command Sverre Rabbelier
2009-09-06 14:35 ` [PATCH v7 6/6] fast-import: test the new " Sverre Rabbelier
2009-09-12 19:04 ` [PATCH v7 5/6] fast-import: add " Shawn O. Pearce
2009-09-12 19:40 ` Sverre Rabbelier
2009-09-12 18:52 ` [PATCH v7 4/6] fast-import: test the new feature command Shawn O. Pearce
2009-09-12 19:31 ` Sverre Rabbelier
2009-09-13 13:20 ` Miklos Vajna
2009-09-12 18:51 ` [PATCH v7 3/6] fast-import: add " Shawn O. Pearce
2009-09-12 19:43 ` Sverre Rabbelier [this message]
2009-09-12 18:47 ` [PATCH v7 2/6] fast-import: put marks reading in it's own function Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e0909121243l240dcb68jbd0207bd4b21d4ca@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ian.clatworthy@canonical.com \
--cc=julian@quantumfyre.co.uk \
--cc=mlm@aya.yale.edu \
--cc=spearce@spearce.org \
--cc=vcs-fast-import-devs@lists.launchpad.net \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).