From: Sverre Rabbelier <srabbelier@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Anders Melchiorsen" <mail@spoon.kalibalik.dk>,
"Björn Gustavsson" <bgustavsson@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Teach 'rebase -i' the command "amend"
Date: Mon, 5 Oct 2009 23:13:35 +0200 [thread overview]
Message-ID: <fabb9a1e0910051413nf8581c8vdf01508d59c4e1a4@mail.gmail.com> (raw)
In-Reply-To: <7vbpkl8s8x.fsf@alter.siamese.dyndns.org>
Heya,
2009/10/5 Junio C Hamano <gitster@pobox.com>:
> If the rebase insn sheet were richer, and had a way to show the full
> message, like this:
But that's not what rebase -i's insn sheet is about is it? It's not
"rewrite my commits so that they are the way I want them", it's about
"change the order of my commits"/squash some/drop some. The polishing
of the commits itself is done after finishing the insn sheet.
> I do not see why we shouldn't allow people to edit any part of the above
> to reword.
Because it then becomes very hard to do any actual reordering. I'm not
saying it's a bad idea, just that it's a bad idea to do it in 'git
rebase -i', conceptually. Although what you suggest would be useful to
me, I just think it should be a different command, git rewrite perhaps
:P. Definitely not "git rebase -i --rewrite-message" though, becaue it
is not at all about rebasing anymore.
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2009-10-05 21:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-04 19:06 [PATCH] Teach 'rebase -i' the command "amend" Björn Gustavsson
2009-10-04 21:09 ` Johannes Schindelin
2009-10-05 6:08 ` Björn Gustavsson
2009-10-05 6:33 ` Junio C Hamano
2009-10-05 9:17 ` Johannes Schindelin
2009-10-05 9:39 ` Sverre Rabbelier
2009-10-05 16:10 ` Björn Gustavsson
2009-10-05 19:43 ` Anders Melchiorsen
2009-10-05 20:50 ` Johannes Schindelin
2009-10-05 21:07 ` Junio C Hamano
2009-10-05 21:13 ` Sverre Rabbelier [this message]
2009-10-05 21:26 ` Johannes Schindelin
2009-10-06 5:53 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e0910051413nf8581c8vdf01508d59c4e1a4@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=bgustavsson@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mail@spoon.kalibalik.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).