From: Sverre Rabbelier <srabbelier@gmail.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Git List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Johan Herland <johan@herland.net>
Subject: Re: [PATCH 7/7] Factor ref updating out of fetch_with_import
Date: Thu, 29 Oct 2009 10:39:31 -0700 [thread overview]
Message-ID: <fabb9a1e0910291039u3c9d7eb6qe36e25ea76cdddc9@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.0910291311570.14365@iabervon.org>
Heya,
On Thu, Oct 29, 2009 at 10:22, Daniel Barkalow <barkalow@iabervon.org> wrote:
> (a) if HEAD is determined to be a symref, and we care about HEAD, we care
> about whatever HEAD is a symref to; wanted_peer_refs() shouldn't be
> filtering such things out.
It seems that wanted_peer_refs filters out HEAD no matter what though?
> (b) we don't want to make a whole bunch of copies of the ref list to avoid
> updating the mutable ref list that we will look for updated values in; the
> merge of my series with Nico's should replace my copy_ref_list with his
> wanted_peer_refs, not include the copy afterwards. Correcting this should
> lead to the value that matters in the list that will be used having been
> updated directly by transport_fetch_refs().
This I can and will fix. Patch-bomb incoming.
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2009-10-29 17:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 6:40 [PATCH 0/7] Prepare git-remote-helpers series for hg support Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 2/7] .gitignore: add git-remote-cvs Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 3/7] Add notify and warn to util.py Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 4/7] Allow both url and foreign vcs in remote config Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 5/7] Finally make remote helper support useful Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 6/7] When updating refs after a fetch, resolve the symref if set Sverre Rabbelier
2009-10-29 6:40 ` [PATCH 7/7] Factor ref updating out of fetch_with_import Sverre Rabbelier
2009-10-29 14:22 ` Shawn O. Pearce
2009-10-29 15:53 ` Sverre Rabbelier
2009-10-29 15:56 ` Shawn O. Pearce
2009-10-29 16:32 ` Sverre Rabbelier
2009-10-29 17:22 ` Daniel Barkalow
2009-10-29 17:39 ` Sverre Rabbelier [this message]
2009-10-29 18:43 ` Daniel Barkalow
2009-10-29 18:47 ` Sverre Rabbelier
[not found] ` <1256798426-21816-2-git-send-email-srabbelier@gmail.com>
2009-10-29 12:05 ` [PATCH 1/7] Refactor git_remote_cvs to a more generic git_remote_helpers Johan Herland
2009-10-29 15:48 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e0910291039u3c9d7eb6qe36e25ea76cdddc9@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).