From: Sverre Rabbelier <srabbelier@gmail.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Samium Gromoff <_deepfire@feelingofgreen.ru>,
git@vger.kernel.org, Tay Ray Chuan <rctay89@gmail.com>,
Mike Hommey <mh@glandium.org>
Subject: Re: Fw: git-core: SIGSEGV during {peek,ls}-remote on HTTP remotes.
Date: Sun, 1 Nov 2009 21:54:24 +0100 [thread overview]
Message-ID: <fabb9a1e0911011254j316920e6y63c4f129f7df186d@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.0911011504460.14365@iabervon.org>
Heya,
On Sun, Nov 1, 2009 at 21:16, Daniel Barkalow <barkalow@iabervon.org> wrote:
> If we change the ls-remote.c case, it becomes impossible for a struct
> transport to ever have a NULL remote field. And the change to ls-remote
> removes a special case. I'd go so far as to say that ls-remote.c should
> provide a struct remote, and transport_get should enforce that there's a
> struct remote.
If that is the case (that we can eliminate the only special case), I
agree that we should fix it there, where it will be the least effort.
I got the impression from Junio's original post that there are
multiple places that would have to be fixed, and I figured that we
should fix it where it will be the least amount of effort :).
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2009-11-01 20:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 22:07 Fw: git-core: SIGSEGV during {peek,ls}-remote on HTTP remotes Samium Gromoff
2009-11-01 4:27 ` Junio C Hamano
2009-11-01 14:46 ` Sverre Rabbelier
2009-11-01 20:16 ` Daniel Barkalow
2009-11-01 20:54 ` Sverre Rabbelier [this message]
2009-11-02 4:10 ` Junio C Hamano
2009-11-01 19:43 ` Daniel Barkalow
2009-11-01 20:15 ` Junio C Hamano
2009-11-01 21:19 ` Daniel Barkalow
2009-11-01 23:04 ` Jeff King
2009-11-02 0:59 ` Daniel Barkalow
2009-11-02 19:21 ` Clemens Buchacher
2009-11-01 8:19 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e0911011254j316920e6y63c4f129f7df186d@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=_deepfire@feelingofgreen.ru \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mh@glandium.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).