git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sverre Rabbelier <srabbelier@gmail.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Git List <git@vger.kernel.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Johan Herland <johan@herland.net>
Subject: Re: [PATCH v2 09/13] Honour the refspec when updating refs after  import
Date: Thu, 5 Nov 2009 02:45:46 +0100	[thread overview]
Message-ID: <fabb9a1e0911041745x577f7e4rc678da4d7d559193@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.0911041624401.14365@iabervon.org>

Heya,

On Wed, Nov 4, 2009 at 22:30, Daniel Barkalow <barkalow@iabervon.org> wrote:
> On Wed, 4 Nov 2009, Sverre Rabbelier wrote:
>> On Wed, Nov 4, 2009 at 22:20, Daniel Barkalow <barkalow@iabervon.org> wrote:
>> > That's not true for "git pull <url> <branch>"; we do want the remote ref,
>> > but it doesn't have a local peer.

No, I don't think that's right, when doing a fetch we want to store
the refs somewhere, sure, but not under 'refs/heads/<branch>', perhaps
'refs/hg/fetch/<branch>', either way, the current code does not work.

>> >I think going straight to the refspec
>> > command is the right answer.
>>
>> Can you clarity what you mean with "the refspec command"?
>
> Whatever it is that lets the helper tell the transport code where in the
> helper's private namespace to look for refs. I'd been thinking the helper
> would advertize the "refspec" capability, and the transport code would
> call the "refspec" command in order to get the helper to report that; but
> then I actually only said that the helper reports refspec, and not
> proposed a name for the command.

Currently I'm implementing so that it would work like this for the svn helper:

$ echo capabilities | git remote-svn origin /path/to/hg/repo
import
refspec +refs/trunk:refs/svn/origin/trunk
refspec +refs/branches/*:refs/svn/origin/*

That way we can put the refspec in the config file at clone time.

Now I've been browsing through the builtin-fetch code, and it looks
like the main problem is going to be to apply this refspec at all.
I'll have a more extensive look tomorrow.

-- 
Cheers,

Sverre Rabbelier

  reply	other threads:[~2009-11-05  1:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04 19:48 [PATCH v2 00/13] Reroll of the remote-vcs-helper series Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 01/13] Fix memory leak in helper method for disconnect Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 02/13] Allow programs to not depend on remotes having urls Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 03/13] Use a function to determine whether a remote is valid Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 04/13] Allow fetch to modify refs Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 05/13] Add a config option for remotes to specify a foreign vcs Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 06/13] Allow specifying the remote helper in the url Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 07/13] Add support for "import" helper command Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 08/13] Write local refs written by the "import" helper command only once Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 09/13] Honour the refspec when updating refs after import Sverre Rabbelier
2009-11-04 21:20   ` Daniel Barkalow
2009-11-04 21:21     ` Sverre Rabbelier
2009-11-04 21:30       ` Daniel Barkalow
2009-11-05  1:45         ` Sverre Rabbelier [this message]
2009-11-05  5:34           ` Daniel Barkalow
2009-11-05  6:53             ` Daniel Barkalow
2009-11-05 23:51               ` Sverre Rabbelier
2009-11-06  0:19                 ` Daniel Barkalow
2009-11-06  0:28                   ` Sverre Rabbelier
2009-11-06  0:37                     ` Daniel Barkalow
2009-11-06  6:05                       ` Junio C Hamano
2009-11-04 19:48 ` [PATCH v2 10/13] Allow helpers to report in "list" command that the ref is unchanged Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 11/13] Allow helpers to request the path to the .git directory Sverre Rabbelier
2009-11-04 21:35   ` Daniel Barkalow
2009-11-04 22:06     ` Sverre Rabbelier
2009-11-04 22:27       ` Daniel Barkalow
2009-11-04 22:42         ` Sverre Rabbelier
2009-11-04 23:17           ` Daniel Barkalow
2009-11-04 23:18             ` Sverre Rabbelier
2009-11-04 23:25               ` Daniel Barkalow
2009-11-05  0:04       ` Junio C Hamano
2009-11-05  0:15         ` Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 12/13] Basic build infrastructure for Python scripts Sverre Rabbelier
2009-11-04 19:48 ` [PATCH v2 13/13] Add Python support library for remote helpers Sverre Rabbelier
2009-11-05  7:55   ` Johan Herland
2009-11-06  0:14     ` Sverre Rabbelier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fabb9a1e0911041745x577f7e4rc678da4d7d559193@mail.gmail.com \
    --to=srabbelier@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    --cc=johan@herland.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).