git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sverre Rabbelier <srabbelier@gmail.com>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] remote-curl.c: fix rpc_out()
Date: Mon, 23 Nov 2009 06:53:18 +0100	[thread overview]
Message-ID: <fabb9a1e0911222153n633ade94w179513d4aa42a3d4@mail.gmail.com> (raw)
In-Reply-To: <20091123110338.2b230359.rctay89@gmail.com>

Heya,

On Mon, Nov 23, 2009 at 04:03, Tay Ray Chuan <rctay89@gmail.com> wrote:
>  remote-curl.c |   17 +++++++++++------
>  1 files changed, 11 insertions(+), 6 deletions(-)

Seems like this type of patch would do very well with a test case or two?

-- 
Cheers,

Sverre Rabbelier

  reply	other threads:[~2009-11-23  5:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23  3:03 [PATCH 2/2] remote-curl.c: fix rpc_out() Tay Ray Chuan
2009-11-23  5:53 ` Sverre Rabbelier [this message]
2009-11-23  8:38   ` Tay Ray Chuan
2009-11-23 10:39     ` Johannes Schindelin
2009-11-23 17:54       ` Tay Ray Chuan
2009-11-23 21:04 ` Shawn O. Pearce
2009-11-24  1:35   ` Tay Ray Chuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fabb9a1e0911222153n633ade94w179513d4aa42a3d4@mail.gmail.com \
    --to=srabbelier@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rctay89@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).