From: Sverre Rabbelier <srabbelier@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Juliusz Chroboczek <jch@pps.jussieu.fr>, git@vger.kernel.org
Subject: Re: git-format-patch should include a checksum
Date: Wed, 27 Jan 2010 00:26:44 +0100 [thread overview]
Message-ID: <fabb9a1e1001261526tc86c04em4c6ede23e109e66@mail.gmail.com> (raw)
In-Reply-To: <7vljfkxxj9.fsf@alter.siamese.dyndns.org>
Heya,
On Wed, Jan 27, 2010 at 00:21, Junio C Hamano <gitster@pobox.com> wrote:
> format-patch/am pair is designed to be lenient, allowing people to write
> additional messages after the three-dash lines after the output is made
> but before it is given to the MUA for sending the result out, for example,
> so adding a checksum over the entire output and forcing a check upon
> application is really a bad idea, even though, provided if the patch is
> done cleanly, it might be acceptable as an optional feature.
I would imagine that the checksum is taken over just the actual commit
message, perhaps author information, and use the patch-id for the
patch itself, that way any comments after triple dash would be ignored, right?
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2010-01-26 23:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 22:34 git-format-patch should include a checksum Juliusz Chroboczek
2010-01-26 23:15 ` Sverre Rabbelier
2010-01-26 23:21 ` Junio C Hamano
2010-01-26 23:26 ` Sverre Rabbelier [this message]
2010-01-27 0:45 ` Linus Torvalds
2010-01-27 0:50 ` Sverre Rabbelier
2010-01-27 1:13 ` Nicolas Pitre
2010-01-27 1:25 ` Junio C Hamano
2010-01-27 1:25 ` Juliusz Chroboczek
2010-01-27 1:35 ` Junio C Hamano
2010-01-27 3:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e1001261526tc86c04em4c6ede23e109e66@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jch@pps.jussieu.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).