From: Sverre Rabbelier <srabbelier@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Juliusz Chroboczek <jch@pps.jussieu.fr>,
git@vger.kernel.org
Subject: Re: git-format-patch should include a checksum
Date: Wed, 27 Jan 2010 01:50:57 +0100 [thread overview]
Message-ID: <fabb9a1e1001261650r18e04e3cw2efade6072a426b@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1001261639550.17519@localhost.localdomain>
Heya,
On Wed, Jan 27, 2010 at 01:45, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> That wouldn't work either. People can, should, and do add extra things to
> the message before applying it.
Ah, that's a fair point.
> In short, it might make sense to have some anti-corruption logic, but I
> suspect it needs a lot of thought.
Perhaps it makes sense to make it a separate mode to git am, such that
it only checks that the patch is not corrupted, but does not apply it.
That way it would be possible to download the patch, check that it
arrived unscathed, and then do your usual patch handling. Those who do
not edit patches before applying it would be convenient to set a
configuration option that automatically does it when applying the
patch, either warning about it or aborting (as Juliusz suggested).
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2010-01-27 0:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 22:34 git-format-patch should include a checksum Juliusz Chroboczek
2010-01-26 23:15 ` Sverre Rabbelier
2010-01-26 23:21 ` Junio C Hamano
2010-01-26 23:26 ` Sverre Rabbelier
2010-01-27 0:45 ` Linus Torvalds
2010-01-27 0:50 ` Sverre Rabbelier [this message]
2010-01-27 1:13 ` Nicolas Pitre
2010-01-27 1:25 ` Junio C Hamano
2010-01-27 1:25 ` Juliusz Chroboczek
2010-01-27 1:35 ` Junio C Hamano
2010-01-27 3:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e1001261650r18e04e3cw2efade6072a426b@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jch@pps.jussieu.fr \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).