From: Sverre Rabbelier <srabbelier@gmail.com>
To: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Cc: git@vger.kernel.org, Tor Arvid Lund <torarvid@gmail.com>,
Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH v2] Fix remote.<remote>.vcs
Date: Wed, 27 Jan 2010 19:09:10 +0100 [thread overview]
Message-ID: <fabb9a1e1001271009m283bd725v9582b7c0c0acbad2@mail.gmail.com> (raw)
In-Reply-To: <1264614797-22394-1-git-send-email-ilari.liusvaara@elisanet.fi>
Heya,
On Wed, Jan 27, 2010 at 18:53, Ilari Liusvaara
<ilari.liusvaara@elisanet.fi> wrote:
> Fix this by making VCS set by URL to be volatile w.r.t. transport_get()
> instead.
Patch looks good (didn't test it though), but I had to read this line
twice; I'm afraid I don't have any suggestions on how to improve it
though.
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2010-01-27 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 17:53 [PATCH v2] Fix remote.<remote>.vcs Ilari Liusvaara
2010-01-27 18:09 ` Sverre Rabbelier [this message]
2010-01-27 18:39 ` Daniel Barkalow
2010-01-27 18:59 ` Ilari Liusvaara
2010-01-27 20:22 ` Junio C Hamano
2010-01-27 23:54 ` Daniel Barkalow
2010-01-27 19:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e1001271009m283bd725v9582b7c0c0acbad2@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
--cc=torarvid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).