From: Sverre Rabbelier <srabbelier@gmail.com>
To: Lars Damerow <lars@pixar.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add support for GIT_ONE_FILESYSTEM
Date: Tue, 16 Mar 2010 00:16:19 +0100 [thread overview]
Message-ID: <fabb9a1e1003151616m4c0e9100g77170433f6a67912@mail.gmail.com> (raw)
In-Reply-To: <20100315214003.GB11157@pixar.com>
Heya,
On Mon, Mar 15, 2010 at 22:40, Lars Damerow <lars@pixar.com> wrote:
> + if (buf.st_dev != current_device)
> + die("refusing to cross filesystem boundary '%s/..'", cwd);
Great, that's going to tell the unfortunate user who runs into this a
whole lot of nothing. Shouldn't you at least tell them what git was
trying to do, how they can fix it if this is not the desired behavior,
etc. etc.?
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2010-03-15 23:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 21:40 [PATCH] Add support for GIT_ONE_FILESYSTEM Lars Damerow
2010-03-15 23:16 ` Sverre Rabbelier [this message]
2010-03-15 23:36 ` Lars Damerow
2010-03-16 2:33 ` Jeff King
2010-03-16 3:28 ` Lars Damerow
2010-03-16 3:37 ` Jeff King
2010-03-16 4:19 ` Junio C Hamano
2010-03-16 5:56 ` Lars Damerow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e1003151616m4c0e9100g77170433f6a67912@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=git@vger.kernel.org \
--cc=lars@pixar.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).