From: Sverre Rabbelier <srabbelier@gmail.com>
To: Git List <git@vger.kernel.org>,
Daniel Barkalow <barkalow@iabervon.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Martin Waitz <tali@admingilde.org>,
Junio C Hamano <gitster
Subject: Re: [PATCH 2/2] clone: pass the remote name to remote_get
Date: Mon, 22 Mar 2010 00:27:46 +0100 [thread overview]
Message-ID: <fabb9a1e1003211627q7ea75194j941fe9ae23f77b66@mail.gmail.com> (raw)
In-Reply-To: <1269202789-8833-2-git-send-email-srabbelier@gmail.com>
Heya,
On Sun, Mar 21, 2010 at 21:19, Sverre Rabbelier <srabbelier@gmail.com> wrote:
> Currently when using a remote helper to clone a repository, the
> remote helper will be passed the url of the target repository as
> first argument (which represents the name of the remote). This name
> is extracted from transport->remote->name, which is set by
> builtin/clone.c when it calls remote_get with argv[0] as argument.
>
> Fix this by passing the name remote will be set up as instead.
Ah, I forgot a sign-off it seems. Also, these two patches were a bit
more involved before (I didn't arrive at their current form for quite
a few hours), so I guess it could makes sense to just squash them into
one patch. Whichever is preferable.
--
Cheers,
Sverre Rabbelier
prev parent reply other threads:[~2010-03-21 23:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 20:19 [PATCH 1/2] Move setup_reference to after writing the config file Sverre Rabbelier
2010-03-21 20:19 ` [PATCH 2/2] clone: pass the remote name to remote_get Sverre Rabbelier
2010-03-21 23:27 ` Sverre Rabbelier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fabb9a1e1003211627q7ea75194j941fe9ae23f77b66@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=tali@admingilde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).