git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [StGit] How do I get colored diff output?
@ 2007-08-30 12:32 Peter Baumann
  2007-08-30 13:22 ` Catalin Marinas
  0 siblings, 1 reply; 5+ messages in thread
From: Peter Baumann @ 2007-08-30 12:32 UTC (permalink / raw)
  To: git

Hi,

Is there a way to get colored diff output, preferable from the native
git diff without having to specify stg diff -O --color everytime?
It seems that stg doesn't honor color.diff config entry, so I am a
little lost.

(And yes I now that I could use the pager setting given in examples/gitconfig,

	stgit.pager = filterdiff --annotate | colordiff | less -FRX

 but I really prefere the native git coloring, which looks a loot nicer
 and does also highlight traling whitespace)

-Peter

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [StGit] How do I get colored diff output?
  2007-08-30 12:32 [StGit] How do I get colored diff output? Peter Baumann
@ 2007-08-30 13:22 ` Catalin Marinas
  2007-08-30 13:59   ` Peter Baumann
  2007-08-30 16:57   ` Jakub Narebski
  0 siblings, 2 replies; 5+ messages in thread
From: Catalin Marinas @ 2007-08-30 13:22 UTC (permalink / raw)
  To: git

Peter Baumann <waste.manager@gmx.de> wrote:
> Is there a way to get colored diff output, preferable from the native
> git diff without having to specify stg diff -O --color everytime?
> It seems that stg doesn't honor color.diff config entry, so I am a
> little lost.
>
> (And yes I now that I could use the pager setting given in examples/gitconfig,
>
> 	stgit.pager = filterdiff --annotate | colordiff | less -FRX
>
>  but I really prefere the native git coloring, which looks a loot nicer
>  and does also highlight traling whitespace)

There isn't any other way at the moment. There were ideas of adding
support for default command line options for various commands but I
haven't looked at this.

I now tried the example stgit.pager option and it looks bad indeed. In
the meantime, there is a diffcol.sh script in the contrib directory, I
use this instead and it looks much nicer.

-- 
Catalin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [StGit] How do I get colored diff output?
  2007-08-30 13:22 ` Catalin Marinas
@ 2007-08-30 13:59   ` Peter Baumann
  2007-08-30 16:57   ` Jakub Narebski
  1 sibling, 0 replies; 5+ messages in thread
From: Peter Baumann @ 2007-08-30 13:59 UTC (permalink / raw)
  To: Catalin Marinas; +Cc: git

On Thu, Aug 30, 2007 at 02:22:46PM +0100, Catalin Marinas wrote:
> Peter Baumann <waste.manager@gmx.de> wrote:
> > Is there a way to get colored diff output, preferable from the native
> > git diff without having to specify stg diff -O --color everytime?
> > It seems that stg doesn't honor color.diff config entry, so I am a
> > little lost.
> >
> > (And yes I now that I could use the pager setting given in examples/gitconfig,
> >
> > 	stgit.pager = filterdiff --annotate | colordiff | less -FRX
> >
> >  but I really prefere the native git coloring, which looks a loot nicer
> >  and does also highlight traling whitespace)
> 
> There isn't any other way at the moment. There were ideas of adding
> support for default command line options for various commands but I
> haven't looked at this.
> 
> I now tried the example stgit.pager option and it looks bad indeed. In
> the meantime, there is a diffcol.sh script in the contrib directory, I
> use this instead and it looks much nicer.
> 

Ah. I didn't find that while searching for the color ouput.

Thx for your help,
Peter

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [StGit] How do I get colored diff output?
  2007-08-30 13:22 ` Catalin Marinas
  2007-08-30 13:59   ` Peter Baumann
@ 2007-08-30 16:57   ` Jakub Narebski
  2007-08-31 15:14     ` Catalin Marinas
  1 sibling, 1 reply; 5+ messages in thread
From: Jakub Narebski @ 2007-08-30 16:57 UTC (permalink / raw)
  To: git

Catalin Marinas wrote:

> I now tried the example stgit.pager option and it looks bad indeed. In
> the meantime, there is a diffcol.sh script in the contrib directory, I
> use this instead and it looks much nicer.

That means it should be not removed even though git-diff learned --color...

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [StGit] How do I get colored diff output?
  2007-08-30 16:57   ` Jakub Narebski
@ 2007-08-31 15:14     ` Catalin Marinas
  0 siblings, 0 replies; 5+ messages in thread
From: Catalin Marinas @ 2007-08-31 15:14 UTC (permalink / raw)
  To: Jakub Narebski; +Cc: git

Jakub Narebski <jnareb@gmail.com> wrote:
> Catalin Marinas wrote:
>
>> I now tried the example stgit.pager option and it looks bad indeed. In
>> the meantime, there is a diffcol.sh script in the contrib directory, I
>> use this instead and it looks much nicer.
>
> That means it should be not removed even though git-diff learned
> --color...

It looks nicer than "filterdiff | colordiff" (and probably pretty
similar to the git-diff --color output).

It shouldn't be removed yet because there is no support in StGIT to
pass these options automatically. Since StGIT uses git-diff-tree/index
directly, always passing the --color option to these tools is not
feasible as they cannot detect whether the output is tty or file. This
functionality is currently handled by the pydoc.pager function.

Using git-diff would require a bit of work as well since StGIT first
captures the output and displays it afterwards via pydoc.pager. We
might change this at some point since GIT now has proper support for
PAGER.

-- 
Catalin

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2007-08-31 15:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-30 12:32 [StGit] How do I get colored diff output? Peter Baumann
2007-08-30 13:22 ` Catalin Marinas
2007-08-30 13:59   ` Peter Baumann
2007-08-30 16:57   ` Jakub Narebski
2007-08-31 15:14     ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).