From: "Jayesh Daga via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Justin Tobler <jltobler@gmail.com>,
Ayush Chandekar <ayu.chandekar@gmail.com>,
Siddharth Asthana <siddharthasthana31@gmail.com>,
Jayesh Daga <jayeshdaga99@gmail.com>,
Jayesh Daga <jayeshdaga99@gmail.com>
Subject: [PATCH v2 2/2] unpack-trees: use repository from index instead of global
Date: Tue, 31 Mar 2026 15:34:27 +0000 [thread overview]
Message-ID: <fbdf3271b7b05d9e3afc9aa3d476ccd64f867d08.1774971267.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2258.v2.git.git.1774971267.gitgitgadget@gmail.com>
From: Jayesh Daga <jayeshdaga99@gmail.com>
unpack_trees() currently initializes its repository from the
global 'the_repository', even though a repository instance is
already available via the source index.
Use 'o->src_index->repo' instead of the global variable,
reducing reliance on global repository state.
This is a step towards eliminating global repository usage in
unpack_trees().
Suggested-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
---
unpack-trees.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/unpack-trees.c b/unpack-trees.c
index 191b9d4769..b42020f16b 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -1882,7 +1882,7 @@ static int verify_absent(const struct cache_entry *,
*/
int unpack_trees(unsigned len, struct tree_desc *t, struct unpack_trees_options *o)
{
- struct repository *repo = the_repository;
+ struct repository *repo = o->src_index->repo;
int i, ret;
static struct cache_entry *dfc;
struct pattern_list pl;
--
gitgitgadget
next prev parent reply other threads:[~2026-03-31 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 20:13 [PATCH] unpack-trees: use explicit repository in trace2 calls Jayesh Daga via GitGitGadget
2026-03-31 5:31 ` Patrick Steinhardt
2026-03-31 15:32 ` Junio C Hamano
2026-03-31 20:27 ` Junio C Hamano
2026-03-31 15:34 ` [PATCH v2 0/2] " Jayesh Daga via GitGitGadget
2026-03-31 15:34 ` [PATCH v2 1/2] unpack-trees: use repository from index instead of global Jayesh Daga via GitGitGadget
2026-03-31 15:34 ` Jayesh Daga via GitGitGadget [this message]
2026-03-31 21:35 ` [PATCH v2 0/2] unpack-trees: use explicit repository in trace2 calls Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbdf3271b7b05d9e3afc9aa3d476ccd64f867d08.1774971267.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=ayu.chandekar@gmail.com \
--cc=git@vger.kernel.org \
--cc=jayeshdaga99@gmail.com \
--cc=jltobler@gmail.com \
--cc=siddharthasthana31@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox