From: "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>
To: "David Kastrup" <dak@gnu.org>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Wincent Colaiuta" <win@wincent.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Johannes Sixt" <j.sixt@viscovery.net>,
"Benoit Sigoure" <tsuna@lrde.epita.fr>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR
Date: Wed, 28 Nov 2007 21:27:21 +0700 [thread overview]
Message-ID: <fcaeb9bf0711280627h1ac216bbr98dc986b82a54423@mail.gmail.com> (raw)
In-Reply-To: <85lk8ia1nw.fsf@lola.goethe.zz>
On Nov 28, 2007 9:24 PM, David Kastrup <dak@gnu.org> wrote:
> "Nguyen Thai Ngoc Duy" <pclouds@gmail.com> writes:
>
> > On Nov 28, 2007 8:57 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> >>
> >> It might be POSIX, but there are shells that do not like the
> >> expression 'export VAR=VAL'. To be on the safe side, rewrite them
> >> into 'VAR=VAL' and 'export VAR'.
> >
> > Why leave test scripts behind?
>
> Good keyword: how about starting the basic tests by testing for shell
> features that are known and accepted to be used in git?
>
> That way, we get direct feedback when feature assumptions are
> problematic with some shells.
Uh.. I meant there are "export VAL=VAL" usage in test scripts and they
should be fixed as well. Anyway your idea is nice.
--
Duy
next prev parent reply other threads:[~2007-11-28 14:27 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 9:02 Rebase/cherry-picking idea Wincent Colaiuta
2007-11-26 9:32 ` Benoit Sigoure
2007-11-26 11:27 ` Wincent Colaiuta
2007-11-26 12:34 ` Wincent Colaiuta
2007-11-26 12:39 ` Benoit Sigoure
2007-11-26 12:51 ` Johannes Sixt
2007-11-26 13:15 ` Wincent Colaiuta
2007-11-26 13:41 ` Johannes Schindelin
2007-11-26 13:55 ` Wincent Colaiuta
2007-11-28 8:06 ` Junio C Hamano
2007-11-28 8:52 ` Wincent Colaiuta
2007-11-28 9:47 ` Junio C Hamano
2007-11-28 10:04 ` Wincent Colaiuta
2007-11-28 13:57 ` [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR Johannes Schindelin
2007-11-28 14:09 ` David Kastrup
2007-11-28 14:19 ` Nguyen Thai Ngoc Duy
2007-11-28 14:24 ` David Kastrup
2007-11-28 14:27 ` Nguyen Thai Ngoc Duy [this message]
2007-11-28 14:36 ` Johannes Schindelin
2007-11-28 14:27 ` Johannes Schindelin
2007-11-28 14:21 ` Johannes Sixt
2007-11-28 14:29 ` Johannes Schindelin
2007-11-28 14:39 ` Johannes Sixt
2007-11-28 15:56 ` [PATCH v2] " Johannes Schindelin
2007-11-28 16:03 ` David Kastrup
2007-11-28 22:46 ` Junio C Hamano
2007-11-28 22:53 ` David Kastrup
2007-11-28 23:02 ` Jeff King
2007-11-28 23:10 ` David Kastrup
2007-11-29 7:39 ` Johannes Sixt
2007-11-29 10:17 ` David Kastrup
2007-11-28 23:05 ` Johannes Schindelin
2007-11-28 18:49 ` [PATCH] " Junio C Hamano
2007-11-28 19:03 ` Johannes Schindelin
2007-11-28 22:48 ` Junio C Hamano
2007-11-28 23:08 ` Johannes Schindelin
2007-11-28 14:41 ` David Kastrup
2007-11-28 18:44 ` Rebase/cherry-picking idea Junio C Hamano
2007-11-26 17:26 ` Junio C Hamano
2007-11-26 19:12 ` Marco Costalba
2007-11-27 1:08 ` Shawn O. Pearce
2007-11-27 1:25 ` Junio C Hamano
2007-11-26 13:26 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf0711280627h1ac216bbr98dc986b82a54423@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=tsuna@lrde.epita.fr \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).