From: "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] shortlog: initialize nongit variable
Date: Tue, 25 Mar 2008 22:39:38 +0700 [thread overview]
Message-ID: <fcaeb9bf0803250839p721e1870l8fbc8715b3c6e7cb@mail.gmail.com> (raw)
In-Reply-To: <1206456377-2735-1-git-send-email-szeder@ira.uka.de>
On Tue, Mar 25, 2008 at 9:46 PM, SZEDER Gábor <szeder@ira.uka.de> wrote:
> setup_git_directory_gently() only modifies the value of the nongit
> variable if we are not in a git repository, therefore nongit is left
> uninitialized if we are in a git repository. This sometimes broke
> shortlog when it was not fed with a log on its standard input.
cmd_help() has the same problem. Can you make a similar patch for
cmd_help as well?
Thanks
--
Duy
next prev parent reply other threads:[~2008-03-25 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 14:46 [PATCH] shortlog: initialize nongit variable SZEDER Gábor
2008-03-25 15:39 ` Nguyen Thai Ngoc Duy [this message]
2008-03-25 16:03 ` SZEDER Gábor
2008-03-25 19:58 ` Jonas Fonseca
2008-03-25 21:06 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf0803250839p721e1870l8fbc8715b3c6e7cb@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).