From: "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, "Geoff Russell" <geoffrey.russell@gmail.com>
Subject: Re: [PATCH] Preserve cwd in setup_git_directory()
Date: Thu, 24 Jul 2008 19:40:18 +0700 [thread overview]
Message-ID: <fcaeb9bf0807240540i400fe0d1s7ea8efe72203471d@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0807241324040.8986@racer>
On 7/24/08, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
>
> On Thu, 24 Jul 2008, Nguyen Thai Ngoc Duy wrote:
>
> > When GIT_DIR is not set, cwd is used to determine where .git is. If
> > core.worktree is set, setup_git_directory() needs to jump back to the
> > original cwd in order to calculate worktree, this leads to incorrect
> > .git location later in setup_work_tree().
>
>
> I do not understand. core.worktree is either absolute, in which case
> there is no problem. Or it is relative to where the config lives, no?
The problem is GIT_DIR is not absolute in this case. So cwd must stay
where git dir is until it is absolute-ized by setup_work_tree().
--
Duy
next prev parent reply other threads:[~2008-07-24 12:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 3:14 [PATCH] Preserve cwd in setup_git_directory() Nguyễn Thái Ngọc Duy
2008-07-24 6:50 ` Johannes Sixt
2008-07-24 8:12 ` Nguyen Thai Ngoc Duy
2008-07-24 12:26 ` Johannes Schindelin
2008-07-24 12:40 ` Nguyen Thai Ngoc Duy [this message]
2008-07-24 14:09 ` Johannes Schindelin
2008-07-24 18:37 ` Nguyen Thai Ngoc Duy
2008-07-25 9:48 ` Geoff Russell
2008-07-25 10:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf0807240540i400fe0d1s7ea8efe72203471d@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=geoffrey.russell@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).