From: "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org, "Johannes Sixt" <johannes.sixt@telecom.at>
Subject: Re: [PATCH] Extend index to save more flags
Date: Tue, 2 Sep 2008 14:33:56 +0700 [thread overview]
Message-ID: <fcaeb9bf0809020033i6ed8c268gac3cedcbebe57e26@mail.gmail.com> (raw)
In-Reply-To: <7vhc8zm2ka.fsf@gitster.siamese.dyndns.org>
On 9/2/08, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
> > The on-disk format of index only saves 16 bit flags, nearly all have
> > been used. The last bit (CE_EXTENDED) is used to for future extension.
> >
> > This patch extends index entry format to save more flags in future.
> > The new entry format will be used when CE_EXTENDED bit is 1.
> >
> > Because older implementation may not understand CE_EXTENDED bit and
> > misread the new format, if there is any extended entry in index, index
> > header version will turn 3, which makes it incompatible for older git.
> > If there is none, header version will return to 2 again.
>
>
> I think this is a good change.
Just don't apply it now. There is a bug in die() code for unknown
flags. I'll resend with narrow checkout series, which will also be a
test case for these change.
--
Duy
prev parent reply other threads:[~2008-09-02 7:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 11:32 [PATCH] Extend index to save more flags Nguyễn Thái Ngọc Duy
2008-09-01 13:05 ` Johannes Sixt
2008-09-01 14:16 ` Nguyễn Thái Ngọc Duy
2008-09-02 7:25 ` Junio C Hamano
2008-09-02 7:33 ` Nguyen Thai Ngoc Duy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf0809020033i6ed8c268gac3cedcbebe57e26@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.sixt@telecom.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).