From: "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>
To: "Nicolas Pitre" <nico@cam.org>
Cc: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] rehabilitate 'git index-pack' inside the object store
Date: Tue, 21 Oct 2008 21:57:04 +0700 [thread overview]
Message-ID: <fcaeb9bf0810210757w1c14e0a3x1eb61a589a089f10@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0810202110380.26244@xanadu.home>
On 10/21/08, Nicolas Pitre <nico@cam.org> wrote:
> Before commit d0b92a3f6e it was possible to run 'git index-pack'
> directly in the .git/objects/pack/ directory. Restore that ability.
I am sorry I did not catch this in the first place. While the fix
should be fine for "git index-pack". I wonder what can happen for
other setup_*_gently()'s consumers. Other commands may be affected too
(e.g. running "git apply" or "git bundle" from inside .git). Maybe we
should let setup_*_gently() do read-only stuff only and let its
consumers to handle cwd. I recall Jeff has plan about worktree setup
rework, though could not find the thread. Will think more of it
tomorrow.
--
Duy
next prev parent reply other threads:[~2008-10-21 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 1:17 [PATCH] rehabilitate 'git index-pack' inside the object store Nicolas Pitre
2008-10-21 5:03 ` [PATCH] (squash) add index-pack with git-dir test Junio C Hamano
2008-10-21 14:57 ` Nguyen Thai Ngoc Duy [this message]
2008-10-21 15:02 ` [PATCH] rehabilitate 'git index-pack' inside the object store Jeff King
2008-10-21 15:54 ` Nicolas Pitre
2008-10-21 17:02 ` Johannes Schindelin
2008-10-21 17:43 ` Jeff King
2008-10-21 17:59 ` new plan for cleaning up the worktree mess, was " Johannes Schindelin
2008-10-28 13:52 ` Nguyen Thai Ngoc Duy
2008-10-22 14:04 ` Nguyen Thai Ngoc Duy
2008-10-22 14:57 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf0810210757w1c14e0a3x1eb61a589a089f10@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).