From: "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: "Nicolas Pitre" <nico@cam.org>,
"Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] rehabilitate 'git index-pack' inside the object store
Date: Wed, 22 Oct 2008 21:57:50 +0700 [thread overview]
Message-ID: <fcaeb9bf0810220757w678e303cl6237eb8908261cba@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0810211856090.22125@pacific.mpi-cbg.de.mpi-cbg.de>
On 10/22/08, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> So I propose this change in semantics:
>
> - setup_git_directory_gently(): rename to discover_git_directory(),
> and avoid any chdir() at all.
> - setup_git_directory(): keep the semantics that it chdir()s to the
> worktree, or to the git directory for bare repositories.
>
> Using _gently() even for RUN_SETUP builtins should solve the long standing
> pager problem, too.
Also, from [1] may be only set default git_dir in setup_git_env()
after setup_git_directory() has been called and before
setup_work_tree() is called (if any)? If not, die().
[1] http://article.gmane.org/gmane.comp.version-control.git/98849
--
Duy
prev parent reply other threads:[~2008-10-22 14:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 1:17 [PATCH] rehabilitate 'git index-pack' inside the object store Nicolas Pitre
2008-10-21 5:03 ` [PATCH] (squash) add index-pack with git-dir test Junio C Hamano
2008-10-21 14:57 ` [PATCH] rehabilitate 'git index-pack' inside the object store Nguyen Thai Ngoc Duy
2008-10-21 15:02 ` Jeff King
2008-10-21 15:54 ` Nicolas Pitre
2008-10-21 17:02 ` Johannes Schindelin
2008-10-21 17:43 ` Jeff King
2008-10-21 17:59 ` new plan for cleaning up the worktree mess, was " Johannes Schindelin
2008-10-28 13:52 ` Nguyen Thai Ngoc Duy
2008-10-22 14:04 ` Nguyen Thai Ngoc Duy
2008-10-22 14:57 ` Nguyen Thai Ngoc Duy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf0810220757w678e303cl6237eb8908261cba@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).