From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Thiago Alves <thiago.salves@gmail.com>
Subject: Re: [PATCH 0/5] grep: color search patterns
Date: Tue, 10 Mar 2009 17:01:24 +1100 [thread overview]
Message-ID: <fcaeb9bf0903092301i7bc6322dtbd37f662fe4b224b@mail.gmail.com> (raw)
In-Reply-To: <1236428699.6486.41.camel@ubuntu.ubuntu-domain>
On 3/7/09, René Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:
> Match coloring is a major missing feature of git grep. It makes reading
> the output much easier and brings grep onto the same visual level as the
> other colorized git commands.
"git --color test" did not colorize the result for me. "git --color
--no-ext-grep test" did. Maybe you should ignore external grep unless
it is explicitly requested, like in the last patch. I have very
limited net access these days. Let's see if I can work out something
for tomorrow, unless you beat me to it.
--
Duy
next prev parent reply other threads:[~2009-03-10 6:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-07 12:24 [PATCH 0/5] grep: color search patterns René Scharfe
2009-03-07 12:27 ` [PATCH 1/5] grep: micro-optimize hit collection for AND nodes René Scharfe
2009-03-07 12:28 ` [PATCH 2/5] grep: remove grep_opt argument from match_expr_eval() René Scharfe
2009-03-07 12:30 ` [PATCH 3/5] grep: add pmatch and eflags arguments to match_one_pattern() René Scharfe
2009-03-07 12:32 ` [PATCH 4/5] grep: color patterns in output René Scharfe
2009-03-07 12:34 ` [PATCH 5/5] grep: add support for coloring with external greps René Scharfe
2009-03-10 6:01 ` Nguyen Thai Ngoc Duy [this message]
2009-03-10 16:38 ` [PATCH 0/5] grep: color search patterns René Scharfe
2009-03-16 2:20 ` [PATCH] grep: prefer builtin over external one when coloring results pclouds
2009-03-16 17:31 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf0903092301i7bc6322dtbd37f662fe4b224b@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=thiago.salves@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).