From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: git diff --chunk-pickaxe?
Date: Mon, 22 Jun 2009 23:04:06 +1000 [thread overview]
Message-ID: <fcaeb9bf0906220604ubb9db7v9ea37416080eecd7@mail.gmail.com> (raw)
In-Reply-To: <4A3F7DAC.3090709@lsrfire.ath.cx>
On Mon, Jun 22, 2009 at 10:48 PM, René
Scharfe<rene.scharfe@lsrfire.ath.cx> wrote:
> Nguyen Thai Ngoc Duy schrieb:
>> What I want is only show diff chunks that add or remove a line that
>> does not start with '#', something like a chunk-level pickaxe. Any
>> pointer where to start? It looks like I can start from
>> xdi_diff_outf(). Just wanted to make sure I won't follow a wrong way
>> from the beginning.
>
> How about creating an external diff driver instead? It could remove all
> lines starting with '#', or normalize such lines to just '#' in case you
> need the line numbers to remain unchanged, then write the filtered
> result into temporary files and compare them with diff. Perhaps this is
> sufficient for your purposes? It should be easier to implement.
Yep. Jakub mentioned textconv privately, which should be enough for
review purpose. However I'm not completely satisfied with it. Let's
say I'm done review and happy with most of the translated strings. I'd
like to commit those strings only (whether comments are committed does
not really matter because I can filter them out with textconv). If I
start "git add -p" up, I'm in trouble again.
--
Duy
prev parent reply other threads:[~2009-06-22 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 12:07 git diff --chunk-pickaxe? Nguyen Thai Ngoc Duy
2009-06-22 12:27 ` Jakub Narebski
2009-06-22 12:48 ` René Scharfe
2009-06-22 13:04 ` Nguyen Thai Ngoc Duy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf0906220604ubb9db7v9ea37416080eecd7@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).