From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/5] grep: skip files outside sparse checkout area
Date: Tue, 4 Aug 2009 20:14:08 +0700 [thread overview]
Message-ID: <fcaeb9bf0908040614r6c1ba65dw98c63a48b82df0aa@mail.gmail.com> (raw)
In-Reply-To: <7vljm4st0w.fsf@alter.siamese.dyndns.org>
2009/7/31 Junio C Hamano <gitster@pobox.com>:
>> @@ -522,8 +524,11 @@ static int grep_cache(struct grep_opt *opt, const char **paths, int cached,
>> continue;
>> hit |= grep_sha1(opt, ce->sha1, ce->name, 0);
>> }
>> - else
>> + else {
>> + if (ce->ce_flags & CE_VALID)
>> + continue;
>> hit |= grep_file(opt, ce->name);
>> + }
>> if (ce_stage(ce)) {
>> do {
>> nr++;
>
> I do not think the new code in this hunk will be reached as the other arm
> of the "else" greps in the index when CE_VALID is set.
>
> Has this series been tested or self-reviewed yet?
Yes and no. It had been tested and self-reviewed back when it was part
of original series. There the new code was CE_NO_CHECKOUT check, not
CE_VALID. I grepped through and replaced with CE_VALID to form a new
draft in order to get comments about this direction, this time it was
not well tested because my focus was in the last patch.
--
Duy
next prev parent reply other threads:[~2009-08-04 13:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-29 6:49 [RFC PATCH 0/5] Sparse checkout resurrection Nguyễn Thái Ngọc Duy
2009-07-29 6:49 ` [PATCH 1/5] Prevent diff machinery from examining worktree outside sparse checkout Nguyễn Thái Ngọc Duy
2009-07-29 6:49 ` [PATCH 2/5] grep: skip files outside sparse checkout area Nguyễn Thái Ngọc Duy
2009-07-29 6:49 ` [PATCH 3/5] gitignore: read from index if .gitignore is not in worktree Nguyễn Thái Ngọc Duy
2009-07-29 6:49 ` [PATCH 4/5] unpack_trees(): keep track of unmerged entries Nguyễn Thái Ngọc Duy
2009-07-29 6:49 ` [PATCH 5/5] unpack_trees(): add support for sparse checkout Nguyễn Thái Ngọc Duy
2009-07-29 11:48 ` Jakub Narebski
2009-07-29 23:32 ` Nguyen Thai Ngoc Duy
2009-07-30 0:42 ` Jakub Narebski
2009-07-31 16:55 ` [PATCH 3/5] gitignore: read from index if .gitignore is not in worktree Junio C Hamano
2009-07-31 16:42 ` [PATCH 2/5] grep: skip files outside sparse checkout area Junio C Hamano
2009-08-04 13:14 ` Nguyen Thai Ngoc Duy [this message]
2009-07-31 16:34 ` [PATCH 1/5] Prevent diff machinery from examining worktree outside sparse checkout Junio C Hamano
2009-07-31 21:18 ` [RFC PATCH 0/5] Sparse checkout resurrection skillzero
2009-08-04 13:20 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf0908040614r6c1ba65dw98c63a48b82df0aa@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).