From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC/PATCH] t7011: Mark fixed test as such
Date: Mon, 30 Nov 2009 20:18:20 +0700 [thread overview]
Message-ID: <fcaeb9bf0911300518n4d4f96fdg28b13e45c2a4462d@mail.gmail.com> (raw)
In-Reply-To: <4B13BF3D.7010503@drmicha.warpmail.net>
On 11/30/09, Michael J Gruber <git@drmicha.warpmail.net> wrote:
> Regarding 16/17: Seeing a FIXED is very misleading. I caught it during
> my work on a patch series and was confused. FIXED usually occurs only
> while working on a fix, before adjusting the test. So, unless the reroll
> of nd/sparse is to happen very soon, I still suggest marking it as
> expect_success as proposed, and then modifying the test during the reroll.
I won't work on it until this weekend. If you insist, then better put
command "true" after test_must_fail to indicate that the test is
broken (could be line-wrapped by gmail, but it's simple enough to
recreate)
diff --git a/t/t7011-skip-worktree-reading.sh b/t/t7011-skip-worktree-reading.sh
index e996928..da8dcbb 100755
--- a/t/t7011-skip-worktree-reading.sh
+++ b/t/t7011-skip-worktree-reading.sh
@@ -152,6 +152,7 @@ test_expect_failure 'commit on skip-worktree
absent entries' '
git reset &&
setup_absent &&
test_must_fail git commit -m null 1
+ true
'
test_expect_failure 'commit on skip-worktree dirty entries' '
--
Duy
prev parent reply other threads:[~2009-11-30 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 18:24 [RFC/PATCH] t7011: Mark fixed test as such Michael J Gruber
2009-11-29 8:47 ` Nguyen Thai Ngoc Duy
2009-11-29 13:57 ` Michael J Gruber
2009-11-30 1:56 ` Nguyen Thai Ngoc Duy
2009-11-30 12:49 ` Michael J Gruber
2009-11-30 13:18 ` Nguyen Thai Ngoc Duy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf0911300518n4d4f96fdg28b13e45c2a4462d@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).