From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Jonathan del Strother <maillist@steelskies.com>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: git-status segmentation fault in master / OS X
Date: Wed, 20 Jan 2010 19:58:54 +0700 [thread overview]
Message-ID: <fcaeb9bf1001200458v436a8adeq5cfc6753900e6c0c@mail.gmail.com> (raw)
In-Reply-To: <57518fd11001200243v416aa5f9o37a3b5b92bef3b57@mail.gmail.com>
On 1/20/10, Jonathan del Strother <maillist@steelskies.com> wrote:
> One thing I wondered about from that commit - shouldn't the "buf =
> xmalloc(size);" on dir.c:252 be "buf = xmalloc(size+1);" ? I haven't
> really looked at the program flow there, so may be wrong...
You would also need to revert 66c3fa0 (Avoid writing to buffer in
add_excludes_from_file_1() - 2009-08-20) and see if it fixes the
problem. I think there is a potential memory corruption at "buf[i - (i
&& buf[i-1] == '\r')] = 0;". Don't know if it is the cause though.
--
Duy
next prev parent reply other threads:[~2010-01-20 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 17:59 git-status segmentation fault in master / OS X Jonathan del Strother
2010-01-20 0:41 ` Jeff King
2010-01-20 0:56 ` Junio C Hamano
2010-01-20 10:43 ` Jonathan del Strother
2010-01-20 12:58 ` Nguyen Thai Ngoc Duy [this message]
2010-01-20 14:09 ` [PATCH] Fix memory corruption when .gitignore does not end by \n Nguyễn Thái Ngọc Duy
2010-01-20 19:51 ` Junio C Hamano
2010-01-21 1:38 ` Nguyen Thai Ngoc Duy
2010-01-21 6:08 ` Jonathan del Strother
2010-01-21 6:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcaeb9bf1001200458v436a8adeq5cfc6753900e6c0c@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=maillist@steelskies.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).