git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org,
	"João Carlos Mendes Luís" <jonny@jonny.eng.br>
Subject: Re: [PATCH] Support working directory located at root
Date: Tue, 9 Feb 2010 19:27:15 +0700	[thread overview]
Message-ID: <fcaeb9bf1002090427g51754d16tb89b0ae5ba6cada8@mail.gmail.com> (raw)
In-Reply-To: <mtranet.20100209081652.392409790@telekom.at>

On 2/9/10, Johannes Sixt <j6t@kdbg.org> wrote:
> Nguyen Thai Ngoc Duy schrieb:
>
> > But I suspect my change in this code is not enough and caused
>  > the problem (on msys?) for Hannes.
>
>
> My test was on Linux, btw, roughly:
>
>  cd /
>  git init
>  cd etc
>  git add resolv.conf

OK. Just a wild guess since you're mingw port guy :-)

I changed offset near the end of setup_git_*_gently, and in turn
screwed up prefix calculation. I probably forgot to unset
GIT_WORK_TREE while testing. Will work on a test script first before
getting back to the patch. I think I can solve the DOS drive case too.
Just checking, UNC path is not affected, right?
-- 
Duy

  reply	other threads:[~2010-02-09 12:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-09  7:16 [PATCH] Support working directory located at root Johannes Sixt
2010-02-09 12:27 ` Nguyen Thai Ngoc Duy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-02-08 14:53 Nguyễn Thái Ngọc Duy
2010-02-08 17:43 ` Junio C Hamano
2010-02-09  2:18   ` Nguyen Thai Ngoc Duy
2010-02-09  2:49     ` Nguyen Thai Ngoc Duy
2010-02-08 21:29 ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcaeb9bf1002090427g51754d16tb89b0ae5ba6cada8@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=jonny@jonny.eng.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).