git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 3/4] Support working directory located at root
Date: Thu, 11 Feb 2010 19:44:51 +0700	[thread overview]
Message-ID: <fcaeb9bf1002110444v4ada90f5t8fd7d9163956c9f3@mail.gmail.com> (raw)
In-Reply-To: <201002092019.45134.j6t@kdbg.org>

On 2/10/10, Johannes Sixt <j6t@kdbg.org> wrote:
> On Dienstag, 9. Februar 2010, Nguyễn Thái Ngọc Duy wrote:
>  >  I said I would have code change for DOS drive too. But I take it back.
>  >  Supporting GIT_DIR=C:\.git might be easy, GIT_DIR=C:.git is not.
>
>
> One does not set GIT_DIR=C:.git; it would be insane because it means ".git in
>  an unpredictable directory somewhere on drive C". It would be great to
>  support GIT_DIR=C:/.git

A bit off topic, but make_relative_path() may need more care for the
Windows port. I thought of making relative path between C:/foo and
D:/bar but it should work well for that case. //machine/share1/foo and
//machine/share2/bar may fail though.
-- 
Duy

  reply	other threads:[~2010-02-11 12:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-09 17:02 [PATCH 1/4] make_absolute_path(): Do not append redundant slash Nguyễn Thái Ngọc Duy
2010-02-09 17:02 ` [PATCH 2/4] rev-parse: make --git-dir return /.git instead of //.git Nguyễn Thái Ngọc Duy
2010-02-09 19:18   ` Johannes Sixt
2010-02-11 10:07     ` Nguyen Thai Ngoc Duy
2010-02-09 17:02 ` [PATCH 3/4] Support working directory located at root Nguyễn Thái Ngọc Duy
2010-02-09 19:19   ` Johannes Sixt
2010-02-11 12:44     ` Nguyen Thai Ngoc Duy [this message]
2010-02-09 17:02 ` [PATCH 4/4] Add test for using Git at root of file system Nguyễn Thái Ngọc Duy
2010-02-10 13:10   ` João Carlos Mendes Luís
2010-02-11 10:01     ` Nguyen Thai Ngoc Duy
2010-02-09 19:10 ` [PATCH 1/4] make_absolute_path(): Do not append redundant slash Johannes Sixt
2010-02-11 10:00   ` Nguyen Thai Ngoc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcaeb9bf1002110444v4ada90f5t8fd7d9163956c9f3@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).