git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alex Riesen <raa.lkml@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Allow passing of configuration parameters in the command  line
Date: Sat, 20 Mar 2010 16:09:47 +0700	[thread overview]
Message-ID: <fcaeb9bf1003200209r6051f906kf2a0a1e96752845e@mail.gmail.com> (raw)
In-Reply-To: <7vmxy4kss9.fsf@alter.siamese.dyndns.org>

On 3/20/10, Junio C Hamano <gitster@pobox.com> wrote:
> Alex Riesen <raa.lkml@gmail.com> writes:
>
>  > The values passed this way will override whatever is defined
>  > in the config files.
>  >
>  > Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
>  > ---
>  >
>  > Someone wanted to have this once. I accidentally remembered
>  > that when I wanted to temporarily set some config parameter
>  > (format.suffix?). From looking at code it seemed simple enough,
>  > so I did it.
>
>
> How does this interact with core.worktree and the setup sequence in
>  general?

To me it looks like another config file to the config stack. No thing
can go worse (except that if you have core.worktree in
$GIT_DIR/config, now also specify -c core.worktree=foo, then
core.worktree code would be called twice).

However, specifying "-c foo=relativepath" may surprise users. Current
working directory may have been moved when that config is used.
-- 
Duy

  reply	other threads:[~2010-03-20  9:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-19 14:42 [PATCH] Allow passing of configuration parameters in the command line Alex Riesen
2010-03-19 19:36 ` Junio C Hamano
2010-03-20  9:09   ` Nguyen Thai Ngoc Duy [this message]
2010-03-20  9:17     ` Alex Riesen
2010-03-20 16:00 ` Junio C Hamano
2010-03-20 16:03   ` Alex Riesen
2010-03-20 16:20     ` Junio C Hamano
2010-03-20 16:05   ` [PATCH, resend] " Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcaeb9bf1003200209r6051f906kf2a0a1e96752845e@mail.gmail.com \
    --to=pclouds@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=raa.lkml@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).