From: "Eslam reda ragheb via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: eslam reda <eslam.reda.div@gmail.com>,
Eslam reda ragheb <eslam.reda.div@gmail.com>
Subject: [PATCH v4 07/10] t1900: cover repo info path keys and path-format
Date: Thu, 26 Feb 2026 21:14:44 +0000 [thread overview]
Message-ID: <fd18f28db0bac01317c892f14bd9bf16038e07f0.1772140487.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2208.v4.git.git.1772140487.gitgitgadget@gmail.com>
From: Eslam reda ragheb <eslam.reda.div@gmail.com>
Extend t1900 to validate category-key expansion, path.* key
behavior, and --path-format handling for git repo info.
The tests compare repo info output to equivalent rev-parse values.
This ensures behavior remains aligned with existing plumbing
semantics.
Also keep mixed key/category ordering coverage so callers can rely
on deterministic output order when combining explicit keys with
category requests.
Signed-off-by: Eslam reda ragheb <eslam.reda.div@gmail.com>
---
t/t1900-repo.sh | 196 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 196 insertions(+)
diff --git a/t/t1900-repo.sh b/t/t1900-repo.sh
index 51d55f11a5..dcacf84cc3 100755
--- a/t/t1900-repo.sh
+++ b/t/t1900-repo.sh
@@ -10,9 +10,40 @@ REPO_INFO_KEYS='
layout.bare
layout.shallow
object.format
+ path.common-dir
+ path.config-file
+ path.git-dir
+ path.git-prefix
+ path.grafts-file
+ path.hooks-directory
+ path.index-file
+ path.logs-directory
+ path.objects-directory
+ path.packed-refs-file
+ path.refs-directory
+ path.shallow-file
+ path.superproject-working-tree
+ path.toplevel
references.format
'
+REPO_INFO_PATH_KEYS='
+ path.common-dir
+ path.config-file
+ path.git-dir
+ path.git-prefix
+ path.grafts-file
+ path.hooks-directory
+ path.index-file
+ path.logs-directory
+ path.objects-directory
+ path.packed-refs-file
+ path.refs-directory
+ path.shallow-file
+ path.superproject-working-tree
+ path.toplevel
+'
+
# Test whether a key-value pair is correctly returned
#
# Usage: test_repo_info <label> <init command> <repo_name> <key> <expected value>
@@ -89,6 +120,171 @@ test_expect_success 'values returned in order requested' '
test_cmp expect actual
'
+test_expect_success 'category key returns all matching keys' '
+ cat >expect <<-\EOF &&
+ layout.bare=false
+ layout.shallow=false
+ EOF
+ git init category-layout &&
+ git -C category-layout repo info layout >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'mixed key/category requests preserve request order' '
+ cat >expect <<-EOF &&
+ object.format=$(test_oid algo)
+ layout.bare=false
+ layout.shallow=false
+ EOF
+ git init mixed-order &&
+ git -C mixed-order repo info object.format layout >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'path.git-dir matches rev-parse --absolute-git-dir' '
+ git init path-git-dir &&
+ expected_value=$(git -C path-git-dir rev-parse --absolute-git-dir) &&
+ echo "path.git-dir=$expected_value" >expect &&
+ git -C path-git-dir repo info path.git-dir >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'path.common-dir matches rev-parse --git-common-dir' '
+ git init path-common-dir &&
+ expected_value=$(git -C path-common-dir rev-parse --path-format=absolute --git-common-dir) &&
+ echo "path.common-dir=$expected_value" >expect &&
+ git -C path-common-dir repo info path.common-dir >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'path.toplevel matches rev-parse --show-toplevel' '
+ git init path-toplevel &&
+ expected_value=$(git -C path-toplevel rev-parse --show-toplevel) &&
+ echo "path.toplevel=$expected_value" >expect &&
+ git -C path-toplevel repo info path.toplevel >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'path.toplevel is empty in bare repository' '
+ git init --bare bare-path-toplevel &&
+ echo "path.toplevel=" >expect &&
+ git -C bare-path-toplevel repo info path.toplevel >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'path.git-prefix matches rev-parse --show-prefix' '
+ git init path-prefix &&
+ mkdir -p path-prefix/a/b &&
+ expected_value=$(git -C path-prefix/a/b rev-parse --show-prefix) &&
+ echo "path.git-prefix=$expected_value" >expect &&
+ git -C path-prefix/a/b repo info path.git-prefix >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'git-path style keys match rev-parse --git-path' '
+ git init path-git-path &&
+
+ expected_value=$(git -C path-git-path rev-parse --path-format=absolute --git-path info/grafts) &&
+ echo "path.grafts-file=$expected_value" >expect &&
+ git -C path-git-path repo info path.grafts-file >actual &&
+ test_cmp expect actual &&
+
+ expected_value=$(git -C path-git-path rev-parse --path-format=absolute --git-path index) &&
+ echo "path.index-file=$expected_value" >expect &&
+ git -C path-git-path repo info path.index-file >actual &&
+ test_cmp expect actual &&
+
+ expected_value=$(git -C path-git-path rev-parse --path-format=absolute --git-path objects) &&
+ echo "path.objects-directory=$expected_value" >expect &&
+ git -C path-git-path repo info path.objects-directory >actual &&
+ test_cmp expect actual &&
+
+ expected_value=$(git -C path-git-path rev-parse --path-format=absolute --git-path hooks) &&
+ echo "path.hooks-directory=$expected_value" >expect &&
+ git -C path-git-path repo info path.hooks-directory >actual &&
+ test_cmp expect actual &&
+
+ expected_value=$(git -C path-git-path rev-parse --path-format=absolute --git-path config) &&
+ echo "path.config-file=$expected_value" >expect &&
+ git -C path-git-path repo info path.config-file >actual &&
+ test_cmp expect actual &&
+
+ expected_value=$(git -C path-git-path rev-parse --path-format=absolute --git-path logs) &&
+ echo "path.logs-directory=$expected_value" >expect &&
+ git -C path-git-path repo info path.logs-directory >actual &&
+ test_cmp expect actual &&
+
+ expected_value=$(git -C path-git-path rev-parse --path-format=absolute --git-path packed-refs) &&
+ echo "path.packed-refs-file=$expected_value" >expect &&
+ git -C path-git-path repo info path.packed-refs-file >actual &&
+ test_cmp expect actual &&
+
+ expected_value=$(git -C path-git-path rev-parse --path-format=absolute --git-path refs) &&
+ echo "path.refs-directory=$expected_value" >expect &&
+ git -C path-git-path repo info path.refs-directory >actual &&
+ test_cmp expect actual &&
+
+ expected_value=$(git -C path-git-path rev-parse --path-format=absolute --git-path shallow) &&
+ echo "path.shallow-file=$expected_value" >expect &&
+ git -C path-git-path repo info path.shallow-file >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'path.superproject-working-tree is empty when not a submodule' '
+ git init path-superproject &&
+ echo "path.superproject-working-tree=" >expect &&
+ git -C path-superproject repo info path.superproject-working-tree >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'path.superproject-working-tree matches rev-parse in submodule' '
+ git init path-superproject-origin &&
+ echo x >path-superproject-origin/x &&
+ git -C path-superproject-origin add x &&
+ git -C path-superproject-origin commit -m x &&
+
+ git init path-superproject-parent &&
+ git -C path-superproject-parent -c protocol.file.allow=always submodule add ../path-superproject-origin sm &&
+
+ expected_value=$(git -C path-superproject-parent/sm rev-parse --show-superproject-working-tree) &&
+ echo "path.superproject-working-tree=$expected_value" >expect &&
+ git -C path-superproject-parent/sm repo info path.superproject-working-tree >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'path category returns all path keys' '
+ git init path-category &&
+ >expect &&
+ for key in $REPO_INFO_PATH_KEYS
+ do
+ git -C path-category repo info "$key" >>expect || return 1
+ done &&
+ git -C path-category repo info path >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'path-format=relative matches rev-parse for git-dir' '
+ git init path-format-relative &&
+ expected_value=$(git -C path-format-relative rev-parse --path-format=relative --git-dir) &&
+ echo "path.git-dir=$expected_value" >expect &&
+ git -C path-format-relative repo info --path-format=relative path.git-dir >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'git repo info uses the last requested path format' '
+ git init path-format-last &&
+ expected_value=$(git -C path-format-last rev-parse --path-format=relative --git-dir) &&
+ echo "path.git-dir=$expected_value" >expect &&
+ git -C path-format-last repo info --path-format=absolute --path-format=relative path.git-dir >actual &&
+ test_cmp expect actual
+'
+
+test_expect_success 'git-repo-info aborts when requesting an invalid path format' '
+ echo "fatal: invalid path format ${SQ}foo${SQ}" >expect &&
+ test_must_fail git repo info --path-format=foo path.git-dir 2>actual &&
+ test_cmp expect actual
+'
+
test_expect_success 'git-repo-info fails if an invalid key is requested' '
echo "error: key ${SQ}foo${SQ} not found" >expect &&
test_must_fail git repo info foo 2>actual &&
--
gitgitgadget
next prev parent reply other threads:[~2026-02-26 21:14 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-22 18:28 [PATCH 0/3] repo: extend info path reporting and structure statistics eslam reda via GitGitGadget
2026-02-22 18:28 ` [PATCH 1/3] repo: extend info paths " eslam-reda-div via GitGitGadget
2026-02-22 20:35 ` Lucas Seiki Oshiro
2026-02-23 3:02 ` Justin Tobler
2026-02-22 18:28 ` [PATCH 2/3] t1900,t1901: make repo tests hash-agnostic and wc-portable Eslam reda ragheb via GitGitGadget
2026-02-22 20:46 ` Lucas Seiki Oshiro
2026-02-22 18:28 ` [PATCH 3/3] t1900,t1901: fix test portability issues Eslam reda ragheb via GitGitGadget
2026-02-22 22:37 ` [PATCH 0/3] repo: extend info path reporting and structure statistics Junio C Hamano
2026-02-23 14:21 ` [PATCH v2 0/9] " eslam reda via GitGitGadget
2026-02-23 14:21 ` [PATCH v2 1/9] repo: teach info context and category keys Eslam reda ragheb via GitGitGadget
2026-02-23 14:21 ` [PATCH v2 2/9] repo: add path keys to repo info Eslam reda ragheb via GitGitGadget
2026-02-23 14:21 ` [PATCH v2 4/9] repo: add structure max object size metrics Eslam reda ragheb via GitGitGadget
2026-02-23 14:21 ` [PATCH v2 5/9] repo: add structure topology and path-depth metrics Eslam reda ragheb via GitGitGadget
2026-02-23 14:21 ` [PATCH v2 6/9] repo: add aggregate structure totals to keyvalue output Eslam reda ragheb via GitGitGadget
2026-02-23 14:21 ` [PATCH v2 7/9] t1900: cover repo info path keys and path-format Eslam reda ragheb via GitGitGadget
2026-02-23 14:21 ` [PATCH v2 8/9] t1901: extend structure metric coverage and portability Eslam reda ragheb via GitGitGadget
2026-02-23 14:21 ` [PATCH v2 9/9] docs: describe repo info path keys and structure metrics Eslam reda ragheb via GitGitGadget
2026-02-23 19:43 ` [PATCH v3 0/5] repo: extend info path reporting and structure statistics eslam reda via GitGitGadget
2026-02-23 19:43 ` [PATCH v3 1/5] repo: teach info context and category keys Eslam reda ragheb via GitGitGadget
2026-02-23 19:43 ` [PATCH v3 2/5] repo: add path keys to repo info Eslam reda ragheb via GitGitGadget
2026-02-23 19:43 ` [PATCH v3 3/5] repo: add --path-format for info path output Eslam reda ragheb via GitGitGadget
2026-02-23 19:43 ` [PATCH v3 4/5] t1900: cover repo info path keys and path-format Eslam reda ragheb via GitGitGadget
2026-02-23 19:43 ` [PATCH v3 5/5] docs: describe repo info path keys Eslam reda ragheb via GitGitGadget
2026-02-26 21:14 ` [PATCH v4 00/10] repo info: add category/path keys and --path-format eslam reda via GitGitGadget
2026-02-26 21:14 ` [PATCH v4 01/10] repo: teach info context and category keys Eslam reda ragheb via GitGitGadget
2026-02-26 23:21 ` Junio C Hamano
2026-02-26 21:14 ` [PATCH v4 02/10] repo: add path keys to repo info Eslam reda ragheb via GitGitGadget
2026-02-26 23:29 ` Junio C Hamano
2026-02-27 9:04 ` Phillip Wood
2026-02-27 19:51 ` Junio C Hamano
2026-03-01 10:36 ` Phillip Wood
2026-03-02 6:42 ` Junio C Hamano
2026-02-26 21:14 ` [PATCH v4 03/10] repo: add --path-format for info path output Eslam reda ragheb via GitGitGadget
2026-02-26 21:14 ` [PATCH v4 04/10] repo: add structure max object size metrics Eslam reda ragheb via GitGitGadget
2026-02-26 21:14 ` [PATCH v4 05/10] repo: add structure topology and path-depth metrics Eslam reda ragheb via GitGitGadget
2026-02-26 21:14 ` [PATCH v4 06/10] repo: add aggregate structure totals to keyvalue output Eslam reda ragheb via GitGitGadget
2026-02-26 21:14 ` Eslam reda ragheb via GitGitGadget [this message]
2026-02-26 21:14 ` [PATCH v4 08/10] t1901: extend structure metric coverage and portability Eslam reda ragheb via GitGitGadget
2026-02-26 21:14 ` [PATCH v4 09/10] docs: describe repo info path keys and structure metrics Eslam reda ragheb via GitGitGadget
2026-02-26 21:14 ` [PATCH v4 10/10] repo: reduce repetition in structure keyvalue output Eslam reda ragheb via GitGitGadget
2026-02-27 19:30 ` [PATCH v5 00/11] repo info: add category/path keys and --path-format eslam reda via GitGitGadget
2026-02-27 19:30 ` [PATCH v5 01/11] repo: teach info context and category keys Eslam reda ragheb via GitGitGadget
2026-02-27 21:42 ` Lucas Seiki Oshiro
2026-02-27 19:30 ` [PATCH v5 02/11] repo: add path keys to repo info Eslam reda ragheb via GitGitGadget
2026-02-27 19:30 ` [PATCH v5 03/11] repo: add --path-format for info path output Eslam reda ragheb via GitGitGadget
2026-02-27 19:30 ` [PATCH v5 04/11] repo: add structure max object size metrics Eslam reda ragheb via GitGitGadget
2026-02-27 19:30 ` [PATCH v5 05/11] repo: add structure topology and path-depth metrics Eslam reda ragheb via GitGitGadget
2026-02-27 19:30 ` [PATCH v5 06/11] repo: add aggregate structure totals to keyvalue output Eslam reda ragheb via GitGitGadget
2026-02-27 19:30 ` [PATCH v5 07/11] t1900: cover repo info path keys and path-format Eslam reda ragheb via GitGitGadget
2026-02-27 19:30 ` [PATCH v5 08/11] t1901: extend structure metric coverage and portability Eslam reda ragheb via GitGitGadget
2026-02-27 19:30 ` [PATCH v5 09/11] docs: describe repo info path keys and structure metrics Eslam reda ragheb via GitGitGadget
2026-02-27 19:30 ` [PATCH v5 10/11] repo: reduce repetition in structure keyvalue output Eslam reda ragheb via GitGitGadget
2026-02-27 19:30 ` [PATCH v5 11/11] repo: refine path keys for repo info Eslam reda ragheb via GitGitGadget
2026-03-01 10:33 ` Phillip Wood
2026-02-27 21:52 ` [PATCH v5 00/11] repo info: add category/path keys and --path-format Lucas Seiki Oshiro
2026-03-02 5:15 ` [PATCH v6 0/6] " eslam reda via GitGitGadget
2026-03-02 5:15 ` [PATCH v6 1/6] repo: introduce repo_info context plumbing Eslam reda ragheb via GitGitGadget
2026-03-02 5:15 ` [PATCH v6 2/6] repo: support category requests in repo info Eslam reda ragheb via GitGitGadget
2026-03-02 5:15 ` [PATCH v6 3/6] repo: add path keys to " Eslam reda ragheb via GitGitGadget
2026-03-02 5:15 ` [PATCH v6 4/6] repo: add --path-format for info path output Eslam reda ragheb via GitGitGadget
2026-03-02 5:15 ` [PATCH v6 5/6] t1900: cover repo info path keys and path-format Eslam reda ragheb via GitGitGadget
2026-03-02 5:15 ` [PATCH v6 6/6] docs: describe repo info path keys Eslam reda ragheb via GitGitGadget
2026-03-18 20:44 ` [PATCH v6 0/6] repo info: add category/path keys and --path-format Jialong Wang
2026-03-19 3:36 ` K Jayatheerth
2026-03-19 20:32 ` Jerry Wang
2026-03-20 1:49 ` K Jayatheerth
2026-03-19 20:58 ` [PATCH v6 5/6] t1900: cover repo info path keys and path-format Jialong Wang
2026-03-19 20:59 ` [PATCH] t1900: cover repo info path keys in non-default layouts Jialong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd18f28db0bac01317c892f14bd9bf16038e07f0.1772140487.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=eslam.reda.div@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox