From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] SubmittingPatches: describe cover letter
Date: Tue, 2 Jun 2026 08:29:11 -0400 [thread overview]
Message-ID: <fd588cff-be2b-4422-9c01-cef06b2ea5fd@gmail.com> (raw)
In-Reply-To: <20260602090808.87837-3-gitster@pobox.com>
On 6/2/2026 5:08 AM, Junio C Hamano wrote:
> We talk about how a commit log message should look like, but do not
> give advice on writing the cover letter to sell a series to widest
> possible audience.
This is a good thing to boost in the documentation.
> +[[cover-letter]]
> +=== Cover Letter
> +
> +The purpose of your cover letter is to sell your changes, explain what
> +they are about, and get your target audience interested enough to read
> +the patches.
> +
> +. Make sure your target audience can understand what the patches are
> + about and why they are needed without prior context.
The thing that I like to say about the cover letter is that this is
your opportunity to communicate why the value of your change is worth
the risk of regressions and the cost of maintenance. Perhaps:
. Every code change comes with risk of regression and maintenance cost.
The cover letter should clearly communicate why the value of your
proposed change is worth applying. You can also describe how the risk
is reduced by the design choices you made while writing the patches.
Or something similar may be helpful? I may just be over explaining.
> +. For a second or subsequent iteration of the same topic, make sure
> + people who missed the earlier discussion can still understand what
> + the patches are about, so they can judge if the topic is worth their
> + time to read and comment on.
> +
> +. To help those who are familiar with earlier iterations, give a
> + summary of changes since the previous rounds.
I find these updates to be particularly helpful, even for GitGitGadget
PRs that include a range-diff automatically. It's good to double-check
the human description of the update against the computed diff.
Thanks,
-Stolee
next prev parent reply other threads:[~2026-06-02 12:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 9:08 [PATCH 0/2] Small updates to SubmittingPatches Junio C Hamano
2026-06-02 9:08 ` [PATCH 1/2] SubmittingPatches: separate typofixes section Junio C Hamano
2026-06-02 14:24 ` Christian Couder
2026-06-02 14:28 ` Junio C Hamano
2026-06-02 15:16 ` Christian Couder
2026-06-02 14:46 ` Kristoffer Haugsbakk
2026-06-02 9:08 ` [PATCH 2/2] SubmittingPatches: describe cover letter Junio C Hamano
2026-06-02 12:07 ` Patrick Steinhardt
2026-06-02 13:36 ` Junio C Hamano
2026-06-02 12:29 ` Derrick Stolee [this message]
2026-06-02 13:43 ` Junio C Hamano
2026-06-02 14:43 ` [PATCH v2 0/2] Small updates to SubmittingPatches Junio C Hamano
2026-06-02 14:43 ` [PATCH v2 1/2] SubmittingPatches: separate typofixes section Junio C Hamano
2026-06-02 14:43 ` [PATCH v2 2/2] SubmittingPatches: describe cover letter Junio C Hamano
2026-06-02 15:24 ` [PATCH v2 0/2] Small updates to SubmittingPatches Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd588cff-be2b-4422-9c01-cef06b2ea5fd@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox