From: Michael Witten <mfwitten@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Thomas Rast <trast@student.ethz.ch>,
Pierre Habouzit <madcoder@debian.org>,
Pascal Obry <pascal@obry.net>, Jay Soffian <jaysoffian@gmail.com>,
David Brown <git@davidb.org>, Matthew Wilcox <matthew@wil.cx>,
"Robin H. Johnson" <robbat2@gentoo.org>,
git@vger.kernel.org
Subject: Re: [PATCH RESEND] send-email: add 'specify-author' option
Date: Thu, 12 Apr 2012 15:41:06 -0000 [thread overview]
Message-ID: <fd7f09d9f7ad4ce2a32e850c0f21cc4c-mfwitten@gmail.com> (raw)
In-Reply-To: <CAMP44s1b=HfhPNkmiEjPnQpupd0FPBNgVyp5Sw=zFVTdqmJXEg@mail.gmail.com>
On Fri, 6 Apr 2012 22:42:16 +0300, Felipe Contreras wrote:
> On Fri, Apr 6, 2012 at 8:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> Some mail servers (Microsoft Exchange) mangle the 'From' header, so
>>> while applying the patches, the author has to be fixed manually.
>>>
>>> This option allows to always specify the author of the commit in the
>>> body of the message, even if the committer is the author.
>>>
>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>> ---
>>
>> I wouldn't say that the existing option names to send-email are great, but
>> I have to say that the one added by this is simply horrible ;-)
>>
>> The first paragraph of the proposed commit log message states the problem
>> it tries to address very clearly, which is good, but is "From: " the only
>> thing that needs this? I am wondering if this should be named and behave
>> more like "--duplicate-header" or "--in-body-header".
>
> I have never seen any other 'in-body-header' other than From, and I
> don't see how that would be useful. Anybody else?
I sometimes like to set an explicit in-body `Date' header. However, Junio
has disagreed vocally about this practice:
Subject: Dates in Commits and other issues of style
(Re: [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL)
Message-ID: <811b01a9-f10e-4444-9e5e-581adaf059c2-mfwitten@gmail.com>
http://article.gmane.org/gmane.comp.version-control.git/171936
Sincerely,
Michael Witten
next prev parent reply other threads:[~2012-04-12 15:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 12:21 [PATCH RESEND] send-email: add 'specify-author' option Felipe Contreras
2012-04-06 12:32 ` Felipe Contreras
2012-04-06 17:14 ` Junio C Hamano
2012-04-06 19:42 ` Felipe Contreras
2012-04-06 20:22 ` Junio C Hamano
2012-04-06 21:48 ` Felipe Contreras
2012-04-06 22:30 ` Junio C Hamano
2012-04-07 11:46 ` Felipe Contreras
2012-04-08 4:45 ` Junio C Hamano
2012-04-12 15:59 ` Michael Witten
2012-04-12 15:41 ` Michael Witten [this message]
2012-04-12 17:40 ` Junio C Hamano
2012-04-06 19:47 ` Thomas Rast
2012-04-06 21:30 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd7f09d9f7ad4ce2a32e850c0f21cc4c-mfwitten@gmail.com \
--to=mfwitten@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@davidb.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
--cc=madcoder@debian.org \
--cc=matthew@wil.cx \
--cc=pascal@obry.net \
--cc=robbat2@gentoo.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).