git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: William Sprent <williams@unity3d.com>
To: Victoria Dye <vdye@github.com>,
	William Sprent via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Derrick Stolee" <derrickstolee@github.com>,
	"Elijah Newren" <newren@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v2] dir: check for single file cone patterns
Date: Thu, 5 Jan 2023 12:39:05 +0100	[thread overview]
Message-ID: <fd873f47-1f7b-b1dc-8a2d-e1bf8fdfcf05@unity3d.com> (raw)
In-Reply-To: <99e3c0f9-ecfa-7c26-eea5-685bc324f674@github.com>

On 05/01/2023 00.48, Victoria Dye wrote:
> 
> I think this is the best way to maintain the current intended behavior of
> cone mode sparse-checkout. While the idea of single file "exceptions" to
> cone patterns has been brought up in the past (I think most recently at the
> Contributor's Summit this past September [1]), it'd be a substantial change
> that's definitely out-of-scope of this small bugfix.
> 
> [1] https://lore.kernel.org/git/YzXwOsaoCdBhHsX1@nand.local/
> 

Thanks for the context. I didn't know that it had been discussed.

>>
>> ...
>>
> 
> And this test ensures the new check is working for the appropriate patterns.
> 
> This patch looks good to me, thanks for finding & fixing the bug!
> 

Thanks for taking the time to review!


      parent reply	other threads:[~2023-01-05 11:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20 14:27 [PATCH] dir: check for single file cone patterns William Sprent via GitGitGadget
2022-12-20 14:33 ` Ævar Arnfjörð Bjarmason
2022-12-21 12:51   ` William Sprent
2023-01-03  8:20 ` [PATCH v2] " William Sprent via GitGitGadget
2023-01-04  6:07   ` Junio C Hamano
2023-01-04 23:48   ` Victoria Dye
2023-01-05  2:16     ` Junio C Hamano
2023-01-05 11:39     ` William Sprent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd873f47-1f7b-b1dc-8a2d-e1bf8fdfcf05@unity3d.com \
    --to=williams@unity3d.com \
    --cc=avarab@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=newren@gmail.com \
    --cc=vdye@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).