git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dragan Simic <dsimic@manjaro.org>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, gitster@pobox.com, rsbecker@nexbridge.com,
	github@seichter.de
Subject: Re: [PATCH v4 4/4] config.txt: describe handling of whitespace further
Date: Thu, 21 Mar 2024 06:31:06 +0100	[thread overview]
Message-ID: <fdaec126df16bf6fe1c1fca9698f7dcc@manjaro.org> (raw)
In-Reply-To: <CAPig+cTgbjCg5jkidEufgHgpkPOZPhfSbd_gbBxOFK=B8mX+fw@mail.gmail.com>

On 2024-03-21 06:21, Eric Sunshine wrote:
> On Thu, Mar 21, 2024 at 1:16 AM Dragan Simic <dsimic@manjaro.org> 
> wrote:
>> On 2024-03-21 06:11, Eric Sunshine wrote:
>> > It should be possible to rephrase it to be more definite, while
>> > dropping the final sentence altogether. Perhaps:
>> >
>> >     Whitespace surrounding `name`, `=` and `value` is ignored. If
>> >     `value` is surrounding by double quotation marks (`"`), all
>> >     characters within the quoted string are retained verbatim,
>> >     including whitespace. Comments starting with either `#` or `;` and
>> >     extending to the end of line are discarded. A line that defines a
>> >     value can be continued to the next line by ending it with a `\`;
>> >     the backslash and the end-of-line are stripped.
>> 
>> Looking good to me, thanks.  I'll include it into the v5, with
>> a small grammar issue fixed.
> 
> For completeness, I should mention that I intentionally reordered the
> topics so that the most common/important ones are mentioned earlier
> rather than later; i.e. (1) surrounding whitespace ignored, (2)
> double-quoted value, (3) comments, (4) `\` line-splicing with.

Hmm, I just noticed that your proposed description actually contains
some issues, e.g. it implies that the value-internal whitespace is
retained verbatim only if the entire value is enclosed in double 
quotation
marks.  I'll try to reword it, so this is fixed.

  reply	other threads:[~2024-03-21  5:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21  4:17 [PATCH v4 0/4] Fix a bug in configuration parsing, and improve tests and documentation Dragan Simic
2024-03-21  4:17 ` [PATCH v4 1/4] config: minor addition of whitespace Dragan Simic
2024-03-21  4:17 ` [PATCH v4 2/4] config: really keep value-internal whitespace verbatim Dragan Simic
2024-03-21  4:17 ` [PATCH v4 3/4] t1300: add more tests for whitespace and inline comments Dragan Simic
2024-03-21  4:55   ` Eric Sunshine
2024-03-21  5:01     ` Dragan Simic
2024-03-21  4:17 ` [PATCH v4 4/4] config.txt: describe handling of whitespace further Dragan Simic
2024-03-21  5:11   ` Eric Sunshine
2024-03-21  5:16     ` Dragan Simic
2024-03-21  5:21       ` Eric Sunshine
2024-03-21  5:31         ` Dragan Simic [this message]
2024-03-21  7:32     ` Junio C Hamano
2024-03-21  4:50 ` [PATCH v4 0/4] Fix a bug in configuration parsing, and improve tests and documentation Eric Sunshine
2024-03-21  4:58   ` Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdaec126df16bf6fe1c1fca9698f7dcc@manjaro.org \
    --to=dsimic@manjaro.org \
    --cc=git@vger.kernel.org \
    --cc=github@seichter.de \
    --cc=gitster@pobox.com \
    --cc=rsbecker@nexbridge.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).