git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@gmail.com>
To: git@vger.kernel.org
Subject: Re: stgit: editing description of patch
Date: Fri, 5 Oct 2007 09:16:17 +0000 (UTC)	[thread overview]
Message-ID: <fe4vd1$4s2$1@sea.gmane.org> (raw)
In-Reply-To: 20071004173929.GD21717@diana.vm.bytemark.co.uk

(for whatever reason, gnus decided that it no longer likes the
authenticated SMTP server, so I'm trying to post via gmane).

On Thu, 04 Oct 2007 19:39:29 +0200, Karl Hasselström wrote:

> On 2007-10-04 12:45:17 -0400, Jon Smirl wrote:
> 
>> Why are the patch name and the short description independent
>> variables? Wouldn't it make more sense to treat these as a single
>> unified item? If I rename the patch it would automatically edit the
>> first line of the description, etc...
> 
> I guess Catalin would have to answer that -- it's "always" been like
> that. But one obvious problem are patches with identical messages --
> just today I created a series of seven patches that all had "debug"
> for a message. Another is that you usually want descriptive commit
> messages, but may want short and easy-to-type patch names.

That's pretty much the case. There are also the historical reasons (quilt
does the same) plus the fact the exporting should really generate shorter
and simpler file names rather than name with capitals and spaces. I've
also seen people writing a single paragraph over several lines without a
short description. You wouldn't really want a patch name that long.

Anyway, 'stg series -d' would show the patch name together with the short
description.

>> When importing a patch from a saved email, stg should strip all the
>> email headers out of the description. I have to manually fix that
>> up.
> 
> Do you do "stg import -M"? That's for importing one or more patches
> contained in an mbox. Without the -M, I think the default is to expect
> plain diff input.

There is also 'stg import -m' for single e-mails rather than mbox. StGIT
should be able to cope with attachments as well.

Catalin

      reply	other threads:[~2007-10-05  9:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-03 23:26 stgit: editing description of patch Jon Smirl
2007-10-04  2:14 ` Jon Smirl
2007-10-04  8:26   ` Karl Hasselström
2007-10-04 13:16     ` Jon Smirl
2007-10-04 15:48       ` Karl Hasselström
2007-10-04 16:45         ` Jon Smirl
2007-10-04 17:39           ` Karl Hasselström
2007-10-05  9:16             ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='fe4vd1$4s2$1@sea.gmane.org' \
    --to=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).