Git development
 help / color / mirror / Atom feed
From: Phillip Wood <phillip.wood123@gmail.com>
To: "Mantas Mikulėnas" <grawity@gmail.com>,
	"Lutz-Christian Quander" <lcq@wateringcan.de>
Cc: git@vger.kernel.org
Subject: Re: [BUG] git-credential-libsecret writes secret to stdout on store
Date: Wed, 22 Apr 2026 14:13:33 +0100	[thread overview]
Message-ID: <fe75e0a5-1a87-4515-b02b-bfbef0366aaf@gmail.com> (raw)
In-Reply-To: <0b2370ed-f3e1-4011-8a2c-8da539759881@gmail.com>

On 22/04/2026 06:49, Mantas Mikulėnas wrote:
>> 2. The direct-invocation pattern shows up widely in distro docs,
>>    StackOverflow answers, and automation scripts -- empirically the
>>    "internal protocol" boundary is porous. Fixing the helper is one
>>    line; documenting the internal boundary across the ecosystem is
>>    not.
>>
>> If the preferred answer is instead "users should only use
>> `git credential approve`", that would also work for me, but it may
>> deserve a note in gitcredentials(7) to steer people away from the
>> direct pattern -- the current docs don't actively discourage it.

Yes, users should be using "git credential", not be running the helpers 
directly. That's why the helpers are installed in a directory that is 
not in $PATH. gitcredentials(7) shows how to set the config setting used 
by "git credential", as far as I can see it does not suggest that users 
should be running the helpers directly.

Thanks

Phillip


      reply	other threads:[~2026-04-22 13:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 11:03 [BUG] git-credential-libsecret writes secret to stdout on store Lutz-Christian Quander
2026-04-21 11:37 ` Mantas Mikulėnas
     [not found]   ` <60cf5f7c-9ccb-4dfe-82e4-9b6e54b3c2c0@wateringcan.de>
2026-04-22  5:49     ` Mantas Mikulėnas
2026-04-22 13:13       ` Phillip Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe75e0a5-1a87-4515-b02b-bfbef0366aaf@gmail.com \
    --to=phillip.wood123@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=grawity@gmail.com \
    --cc=lcq@wateringcan.de \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox