Git development
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Ilia via GitGitGadget <gitgitgadget@gmail.com>, git@vger.kernel.org
Cc: Ilia <ki.stfu@gmail.com>
Subject: Re: [PATCH v2] fsmonitor: check the untracked cache after a trivial response
Date: Mon, 9 Nov 2026 15:47:33 -0500	[thread overview]
Message-ID: <fefa2680-695c-41db-9975-7e972590b969@gmail.com> (raw)
In-Reply-To: <pull.2247.v2.git.1794251653636.gitgitgadget@gmail.com>

On 11/9/2026 2:14 PM, Ilia via GitGitGadget wrote:
>     Changes since v1:
>     
>      * the whole untracked cache is dropped if !worktree
>      * removed the comments as per nits

Thanks for these improvements. The v2 patch LGTM.

>      * rebased against ToT

Generally, you shouldn't do this as the maintainer will apply
your patch in the same spot and handle most merge conflicts
via rerere, but rebasing interrupts that. The main exception
is when you rebase onto a specific topic or with regards to a
large refactor that merged recently.

Thanks,
-Stolee


  reply	other threads:[~2026-11-09 20:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-04 15:19 [PATCH] fsmonitor: check the untracked cache after a trivial response Ilia via GitGitGadget
2026-11-05 15:01 ` Derrick Stolee
2026-11-05 18:24   ` Junio C Hamano
2026-11-09 18:59     ` Ilia K
2026-11-09 19:14 ` [PATCH v2] " Ilia via GitGitGadget
2026-11-09 20:47   ` Derrick Stolee [this message]
2026-11-09 20:58     ` Junio C Hamano
2026-11-09 21:34       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fefa2680-695c-41db-9975-7e972590b969@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=ki.stfu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox