From: Daniel Cheng <j16sdiz+freenet@gmail.com>
To: Marek Zawirski <marek.zawirski@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH JGIT 1/2] Calculate CRC32 on Pack Index v2
Date: Thu, 26 Mar 2009 08:49:18 +0800 [thread overview]
Message-ID: <ff6a9c820903251749q41977ee0wf776a43dc8e420fb@mail.gmail.com> (raw)
In-Reply-To: <49CA3218.9090202@gmail.com>
On Wed, Mar 25, 2009 at 9:31 PM, Marek Zawirski
<marek.zawirski@gmail.com> wrote:
> Hi,
>
> Thanks for spotting this bug.
> (...)
[...]
>
> Have you tested that code? It seems that CRC32 updates is missing in
> write() method... or did I slept too short this night?:)
Sure I have tested some code, the wrong one.
The buggy code is at PackWriter.writeIndex(), and
the test case I have tested is using IndexPack.index().
.. hm...
I am thinking if we can combine two of them.
> Best,
> Marek
>
prev parent reply other threads:[~2009-03-26 0:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 2:53 [JGit] Mismatch CRC in packed objects from `jgit push` Daniel Cheng
2009-03-24 11:13 ` [JGIT Test Case] This (incomplete) test case demo the index wrong CRC bug Daniel Cheng (aka SDiZ)
2009-03-25 6:21 ` [PATCH JGIT 1/2] Calculate CRC32 on Pack Index v2 Daniel Cheng (aka SDiZ)
2009-03-25 6:21 ` [PATCH JGIT 2/2] Test case for pack index CRC Daniel Cheng (aka SDiZ)
2009-03-25 13:31 ` [PATCH JGIT 1/2] Calculate CRC32 on Pack Index v2 Marek Zawirski
2009-03-25 21:59 ` Shawn O. Pearce
2009-03-26 0:49 ` Daniel Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff6a9c820903251749q41977ee0wf776a43dc8e420fb@mail.gmail.com \
--to=j16sdiz+freenet@gmail.com \
--cc=git@vger.kernel.org \
--cc=marek.zawirski@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).