From: "Jessie Hernandez" <git@jessiehernandez.com>
To: "Konstantin Khomoutov" <kostix+git@007spb.ru>
Cc: git@jessiehernandez.com, "David Shrader" <dshrader@lanl.gov>,
git@vger.kernel.org
Subject: Re: ttk error when starting git gui
Date: Fri, 31 Mar 2017 09:45:03 +0200 [thread overview]
Message-ID: <ff7628d7c69ecd3d212b29fec33f6ba1.squirrel@mail.jessiehernandez.com> (raw)
In-Reply-To: <20170331103330.5d7c414b6a0273cefb8508f2@domain007.com>
> On Fri, 31 Mar 2017 08:44:27 +0200
> "Jessie Hernandez" <git@jessiehernandez.com> wrote:
>
> [...]
>> I also got this problem when I wanted to build and run git 2.10.x.
>> I have added the following change to git-gui/git-gui.sh
>>
>> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
>> index 5bc21b878..5ce59ef94 100755
>> --- a/git-gui/git-gui.sh
>> +++ b/git-gui/git-gui.sh
>> @@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure
>> font_ui] set default_config(gui.fontdiff) [font configure font_diff]
>> # TODO: this option should be added to the git-config documentation
>> set default_config(gui.maxfilesdisplayed) 5000
>> -set default_config(gui.usettk) 1
>> +set default_config(gui.usettk) 0
>> set default_config(gui.warndetachedcommit) 1
>> set default_config(gui.tabsize) 8
>> set font_descs {
>>
>>
>> If you guys want I can submit it as a patch.
>> But i assume that 'fixing' this by disabling the feature is not really
>> what we want.
>
> It's possible to have ttk with 8.5 as well (say, here on Debian 8.5
> ships with ttk enabled).
>
> A proper patch would be
>
> -set default_config(gui.usettk) 1
> +set default_config(gui.usettk) [namespace exists ::ttk]
>
> Could you please test it on your system?
>
Yeah that seems to work.
Thanks for this.
I have tried it with git 2.12.2
Jessie Hernandez
next prev parent reply other threads:[~2017-03-31 7:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 17:01 ttk error when starting git gui David Shrader
2017-03-30 19:54 ` Peter van der Does
2017-03-30 20:44 ` Dennis Kaarsemaker
2017-03-30 21:33 ` David Shrader
2017-03-31 6:44 ` Jessie Hernandez
2017-03-31 7:33 ` Konstantin Khomoutov
2017-03-31 7:45 ` Jessie Hernandez [this message]
2017-03-31 7:53 ` Jessie Hernandez
2017-03-31 7:58 ` Konstantin Khomoutov
2017-03-31 11:29 ` Jessie Hernandez
2017-03-31 14:34 ` Konstantin Khomoutov
2017-03-31 7:56 ` Konstantin Khomoutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff7628d7c69ecd3d212b29fec33f6ba1.squirrel@mail.jessiehernandez.com \
--to=git@jessiehernandez.com \
--cc=dshrader@lanl.gov \
--cc=git@vger.kernel.org \
--cc=kostix+git@007spb.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).