Git development
 help / color / mirror / Atom feed
From: Sven Strickroth <email@cs-ware.de>
To: Jeff King <peff@peff.net>
Cc: git <git@vger.kernel.org>
Subject: Re: Git silently broke push-options over ssh?
Date: Sat, 23 Oct 2021 16:57:59 +0200	[thread overview]
Message-ID: <ff7ff6ca-2941-c61e-f36d-0732b367fc64@cs-ware.de> (raw)
In-Reply-To: <YXMku8V9cdHLfXt6@coredump.intra.peff.net>

Am 22.10.2021 um 22:53 schrieb Jeff King:
> On Fri, Oct 22, 2021 at 07:27:14PM +0200, Sven Strickroth wrote:
> 
>> If I understood <https://opensource.googleblog.com/2018/05/introducing-git-protocol-version-2.html>
>> correctly I have to enable the Git protocol version 2 and then the push
>> options should work.
> 
> I don't think that is true. There is no v2 push protocol yet, so the
> push options must work over v0.

You are right. After enabling GIT_TRACE_PACKET I see that the 
push-option gets transmitted correctly.

I got confused was because a GitLab CI pipeline run despite I passed 
ci.skip. The reason why the pipeline ran despite of that flag is that 
some external push hook triggered a CI pipeline action manually - when I 
look at GitLab immediately after the push I see that the pipeline is 
skipped and then the external hook fires...

Thanks for the hint for enabling GIT_TRACE_PACKET  Peff and sorry for 
the noise.

  Sven

      reply	other threads:[~2021-10-23 14:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 17:27 Git silently broke push-options over ssh? Sven Strickroth
2021-10-22 20:53 ` Jeff King
2021-10-23 14:57   ` Sven Strickroth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff7ff6ca-2941-c61e-f36d-0732b367fc64@cs-ware.de \
    --to=email@cs-ware.de \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox