From: Derrick Stolee <derrickstolee@github.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH 2/5] fetch+push tests: add missing coverage for 6dcbdc0d661
Date: Wed, 15 Jun 2022 08:39:02 -0400 [thread overview]
Message-ID: <ffa6d63c-0efb-d805-dc73-a781e5a92f22@github.com> (raw)
In-Reply-To: <RFC-patch-2.5-38af32c5b96-20220615T104503Z-avarab@gmail.com>
On 6/15/22 6:53 AM, Ævar Arnfjörð Bjarmason wrote:
> Add tests that were missing from 6dcbdc0d661 (remote: create
> fetch.credentialsInUrl config, 2022-06-06), we want to test how we
> handle cases where the config comes from a file, and that we handle
> "pushURL" correctly.
The tests use your renamed transfer.credentialsInUrl, but you haven't
renamed at this point.
> Currently the "pushURL" case isn't handled at all, i.e. URLs aren't
> warned about in "remote.*pushurl" , only for "remote.*.url".
Good find. I suppose that the second test_expect_success will _fail_
at the point of this patch?
Thanks,
-Stolee
next prev parent reply other threads:[~2022-06-15 12:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 10:53 [RFC PATCH 0/5] fix issues in transfer.credentialsInUrl Ævar Arnfjörð Bjarmason
2022-06-15 10:53 ` [RFC PATCH 1/5] push tests: add a missing "test_line_count" Ævar Arnfjörð Bjarmason
2022-06-15 10:53 ` [RFC PATCH 2/5] fetch+push tests: add missing coverage for 6dcbdc0d661 Ævar Arnfjörð Bjarmason
2022-06-15 12:39 ` Derrick Stolee [this message]
2022-06-15 10:53 ` [RFC PATCH 3/5] CI: add a linux-BUILD-vars job Ævar Arnfjörð Bjarmason
2022-06-15 12:41 ` Derrick Stolee
2022-06-15 10:53 ` [RFC PATCH 4/5] fetch: stop emitting duplicate transfer.credentialsInUrl=warn warnings Ævar Arnfjörð Bjarmason
2022-06-15 10:53 ` [RFC PATCH 5/5] transport: check remote.<name>pushurl with transfer.credentialsInUrl Ævar Arnfjörð Bjarmason
2022-06-15 12:52 ` [RFC PATCH 0/5] fix issues in transfer.credentialsInUrl Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffa6d63c-0efb-d805-dc73-a781e5a92f22@github.com \
--to=derrickstolee@github.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).