Re: git apply fails with 'error: git apply: failed to read: No such file or directory'

[Phillip Wood <phillip.wood123@gmail.com>]

Hi Premek

Thanks for taking the time to report this issue

On 23/06/2023 13:42, Premek Vysoky wrote:
> What did you do before the bug happened? (Steps to reproduce your issue)
> git clone https://github.com/dotnet/llvm-project
> git -C llvm-project diff --patch --binary --output ../llvm.patch 4b825dc642cb6eb9a060e54bf8d69288fbee4904..30e9e6bc2e9f04e0a75daf4b8088ee91f66069da -- ':(glob)**/*' ':(exclude,glob)**/*.dll' ':(exclude,glob)**/*.Dll' ':(exclude,glob)**/*.exe' ':(exclude,glob)**/*.pdb' ':(exclude,glob)**/*.mdb' ':(exclude,glob)**/*.zip' ':(exclude,glob)**/*.nupkg'
> mkdir foo
> git -C foo init
> git -C foo apply --cached --ignore-space-change ../llvm.patch
> 
> What did you expect to happen? (Expected behavior)
> Patch should be created and applied to another folder
> 
> What happened instead? (Actual behavior)
> git apply fails with 'error: git apply: failed to read: No such file or directory'
> (and returns 128)

This stems from commit f1c0e3946e (apply: reject patches larger than ~1 
GiB, 2022-10-25). Unfortunately it does not provide a very helpful error 
message. I'll submit a patch later to fix that in the next few days.

Best Wishes

Phillip

> What's different between what you expected and what actually happened?
> There is no error. I tried -v, --reject etc but wasn't able to get any details.
> 
> Anything else you want to add:
> This happens in both Windows and Linux environments.
> 
> I tried analyzing file handlers via procmon.exe and could not see anything. git reads the whole patch and then shuts down. No indication of a file it is trying to open.
> 
> I tried excluding more files from the patch and then I was able to create/apply the patch, like so:
> 
> git -C llvm-project diff --patch --binary --output ../llvm.patch 4b825dc642cb6eb9a060e54bf8d69288fbee4904..30e9e6bc2e9f04e0a75daf4b8088ee91f66069da -- ':(glob)**/*' ':(exclude,glob)**/*.dll' ':(exclude,glob)**/*.Dll' ':(exclude,glob)**/*.exe' ':(exclude,glob)**/*.pdb' ':(exclude,glob)**/*.mdb' ':(exclude,glob)**/*.zip' ':(exclude,glob)**/*.nupkg' ':(exclude,glob)bolt' ':(exclude,glob)clang/docs' ':(exclude,glob)clang/www' ':(exclude,glob)flang' ':(exclude,glob)libclc' ':(exclude,glob)lldb' ':(exclude,glob)llvm/docs' ':(exclude,glob)mlir' ':(exclude,glob)openmp' ':(exclude,glob)polly' ':(exclude,glob)pstl' ':(exclude,glob)third-party' ':(exclude,glob)**/tests/**'
> 
> But if I do the opposite and create a patch with only the previously excluded files, I'd expect that it breaks. But this works as well!
> 
> git -C llvm-project diff --patch --binary --output ../llvm.patch 4b825dc642cb6eb9a060e54bf8d69288fbee4904..30e9e6bc2e9f04e0a75daf4b8088ee91f66069da -- ':(glob)bolt' ':(glob)clang/docs' ':(glob)clang/www' ':(glob)flang' ':(glob)libclc' ':(glob)lldb' ':(glob)llvm/docs' ':(glob)mlir' ':(glob)openmp' ':(glob)polly' ':(glob)pstl' ':(glob)third-party' ':(glob)**/tests/**' ':(exclude,glob)**/*.dll' ':(exclude,glob)**/*.Dll' ':(exclude,glob)**/*.exe' ':(exclude,glob)**/*.pdb' ':(exclude,glob)**/*.mdb' ':(exclude,glob)**/*.zip' ':(exclude,glob)**/*.nupkg'
> 
> Only when they are together, git fails. Size of the patch is 1GB but I've had 3GB patches apply successfully before.
> 
> Please review the rest of the bug report below.
> You can delete any lines you don't wish to share.
> 
> 
> [System Info]
> git version:
> git version 2.41.0.windows.1
> cpu: x86_64
> built from commit: ff94e79c4724635915dbb3d4ba38f6bb91528260
> sizeof-long: 4
> sizeof-size_t: 8
> shell-path: /bin/sh
> feature: fsmonitor--daemon
> uname: Windows 10.0 22621
> compiler info: gnuc: 13.1
> libc info: no libc information available
> $SHELL (typically, interactive shell): <unset>
> 
> 
> [Enabled Hooks]
> not run from a git repository - no hooks to show