git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Don't use cpio in git-clone when not installed
Date: Thu, 01 Nov 2007 02:00:48 +0100	[thread overview]
Message-ID: <fgb8b6$hqo$1@ger.gmane.org> (raw)
In-Reply-To: alpine.LFD.0.999.0710311742170.3342@woody.linux-foundation.org

Linus Torvalds wrote:

> 
> 
> On Wed, 31 Oct 2007, Mike Hommey wrote:
>> +    if type cpio > /dev/null 2>&1; then
>> +            local=yes
>> +    fi
> 
> Isn't "type" a bashism?
> 
> Maybe just do
> 
>       if echo . | cpio -o > /dev/null 2>&1; then
> 
> instead? Maybe even doing this at install time to avoid the overhead of 
> executing another process..

Or perhaps trap / check actual execution of cpio in git-clone, and
fallback to ln -s / link if it fails...

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  reply	other threads:[~2007-11-01  0:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31 20:05 [PATCH] Don't use cpio in git-clone when not installed Mike Hommey
2007-10-31 20:10 ` Mike Hommey
2007-10-31 22:29 ` Junio C Hamano
2007-10-31 23:55   ` Johannes Schindelin
2007-11-01  0:46 ` Linus Torvalds
2007-11-01  1:00   ` Jakub Narebski [this message]
2007-11-01  1:05   ` Nguyen Thai Ngoc Duy
2007-11-01  1:12   ` Junio C Hamano
2007-11-01  6:31   ` Mike Hommey
2007-11-01 13:06   ` Alexander Skwar
2007-11-01  1:09 ` Nguyen Thai Ngoc Duy
2007-11-01  1:15   ` Junio C Hamano
2007-11-01  1:25     ` Nguyen Thai Ngoc Duy
2007-11-01  6:45       ` Junio C Hamano
2007-11-01 10:53     ` Mike Hommey
2007-11-01 21:06       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='fgb8b6$hqo$1@ger.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).