git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: Re: Reordering lines in "git-rebase -i" task sheet
Date: Fri, 23 Nov 2007 08:54:38 +0000	[thread overview]
Message-ID: <fi64ge$u1g$1@ger.gmane.org> (raw)
In-Reply-To: 7vlk8q7hzg.fsf@gitster.siamese.dyndns.org

Junio C Hamano wrote:

> Could we please reorder the lines so that list of initial
> "pick"s come first and have the help comment lines at the very
> end?

I'm not convinced that this is a great idea.

Mostly with git-rebase -i one is reordering the most recent commits, which
are at the bottom.  Personally, I am often reordering commits that are as
yet unpushed, so for ease-of-thinking I type

 git rebase -i origin/master

again and again.   Hence the early lines are probably already sorted into a
nice order and it's commits at the bottom of the list that need a bit of
massaging.

At present it's easy to get to them because a shift-G or ctrl-end, or
$END_OF_FILE takes you there.   With the above change it's now more steps
to move to the interesting part.

Now if you were suggesting flipping the sort direction at the same time, I
could get on board - but that is perhaps one confusing step too far.

> That is the reason why git commit leaves the first line empty in
> its initial template.  It is to allow the user to immediately
> start typing.

That's different, for a commit message, the first line is exactly where one
would want to be.

Not a strong objection.



Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com

  parent reply	other threads:[~2007-11-23  8:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-22  9:21 Reordering lines in "git-rebase -i" task sheet Junio C Hamano
2007-11-22 11:15 ` [PATCH] rebase -i: move help to end of todo file Johannes Schindelin
2007-11-22 11:41   ` [PATCH] Adjust t3404 to ignore empty lines in the " Johannes Schindelin
2007-11-22 11:46   ` [PATCH] rebase -i: move help to end of " Junio C Hamano
2007-11-22 12:30     ` Johannes Schindelin
2007-11-22 12:31       ` Jeff King
2007-11-22 11:18 ` [PATCH] rebase -i: give rerere a chance Johannes Schindelin
2007-11-29  0:17   ` Junio C Hamano
2007-11-29  0:22     ` Johannes Schindelin
2007-11-29  9:59       ` David Kastrup
2007-11-22 19:25 ` Reordering lines in "git-rebase -i" task sheet David Brown
2007-11-22 22:11   ` Johannes Schindelin
2007-11-23  8:54 ` Andy Parkins [this message]
2007-11-26 13:14   ` Andy Parkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='fi64ge$u1g$1@ger.gmane.org' \
    --to=andyparkins@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).