From: Gabriel <g2p.code@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Make commit, cherry-pick and revert more silent.
Date: Mon, 7 Jan 2008 08:55:09 +0000 (UTC) [thread overview]
Message-ID: <flspdc$4aa$1@ger.gmane.org> (raw)
In-Reply-To: 7vir2636tq.fsf@gitster.siamese.dyndns.org
Le Sun, 06 Jan 2008 14:52:33 -0800, Junio C Hamano a écrit :
> So a more convincing presentation would be:
> ...
Will split.
> After I wrote all that, I realized that the patch is not acceptable as
> is.
>
> Why?
>
> This makes a successful cherry-pick way too silent. With your patch, we
> will see:
>
> * "Auto-merged ..." messages that shows what paths are affected
> by the cherry-pick/revert (which I do not think we would want to
> squelch),
>
> * "Finished one cherry-pick."
>
> But we will lose the "Created commit ...: <msg>" and "<num> files
> changed..." summary, neither of which we would want to lose.
I'll have a look.
This seems to require refactoring the interface between cherry-pick/
revert and commit.
> Also sign your patch (see Documentation/SubmittingPatches), please, when
> you try the second round.
>
> Thanks.
Thanks, I appreciate the review.
prev parent reply other threads:[~2008-01-07 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 15:43 [PATCH] Make commit, cherry-pick and revert more silent Gabriel
2008-01-06 22:52 ` Junio C Hamano
2008-01-07 8:55 ` Gabriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='flspdc$4aa$1@ger.gmane.org' \
--to=g2p.code@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).