From: Andy Parkins <andyparkins@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Don't force imap.host to be set when imap.tunnel is set
Date: Tue, 22 Apr 2008 16:07:12 +0100 [thread overview]
Message-ID: <fukuv0$aba$1@ger.gmane.org> (raw)
In-Reply-To: 20080422104146.GA11198@sigill.intra.peff.net
Jeff King wrote:
> I think Junio's point is that it's easy to start dereferencing NULL,
> because later parts of the code assume that "host" is always set, even
> if only to use it for informational purposes. So those callsites either
> need to be fixed to handle a NULL host, or perhaps something like this
> instead (totally untested):
Agreed. Yours is a much better solution.
Andy
--
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
prev parent reply other threads:[~2008-04-22 15:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 13:59 [PATCH] Don't force imap.host to be set when imap.tunnel is set Andy Parkins
2008-04-22 6:47 ` Junio C Hamano
2008-04-22 9:11 ` Andy Parkins
2008-04-22 10:41 ` Jeff King
2008-04-22 15:07 ` Andy Parkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='fukuv0$aba$1@ger.gmane.org' \
--to=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).