git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Be more careful with objects directory permissions on clone
Date: Tue, 06 May 2008 09:25:03 +0200	[thread overview]
Message-ID: <fvp14f$8v0$1@ger.gmane.org> (raw)
In-Reply-To: alpine.BSO.1.10.0805051742020.10940@zrgural.vwaro.pbz

Mark Hills wrote:

> -               find objects -depth -print | cpio $cpio_quiet_flag -pumd$l "$GIT_DIR/" || \
> +               # Create dirs using umask and permissions and destination
> +               find objects -type d -print | (cd "$GIT_DIR" && xargs mkdir -p) &&
> +               # Copy existing 0444 permissions on content
> +               find objects ! -type d -print | cpio $cpio_quiet_flag -pumd$l "$GIT_DIR/" || \

By the way, it is important that previous version had -depth, and
proposed one doesn't? Was it about creating directories before files?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  parent reply	other threads:[~2008-05-06  7:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-04 11:37 [PATCH] Be more careful with objects directory permissions on clone Mark Hills
2008-05-05  9:01 ` Johannes Sixt
2008-05-05  9:56   ` Mark Hills
2008-05-05 10:07     ` Johannes Sixt
2008-05-05 10:25       ` Mark Hills
2008-05-05 10:42         ` Johannes Sixt
2008-05-05 16:46           ` Mark Hills
2008-05-06  6:53             ` Junio C Hamano
2008-05-06  7:25             ` Jakub Narebski [this message]
2008-05-06  8:08               ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='fvp14f$8v0$1@ger.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).