From: Alex Riesen <raa.lkml@gmail.com>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [BUG] Git add <device file> silently fails
Date: Sat, 17 Apr 2010 17:27:44 +0200 [thread overview]
Message-ID: <g2h81b0412b1004170827y883c0cc8ofc72712c20e95dc8@mail.gmail.com> (raw)
In-Reply-To: <201004171700.22851.agruen@suse.de>
On Sat, Apr 17, 2010 at 17:00, Andreas Gruenbacher <agruen@suse.de> wrote:
> On Saturday 17 April 2010 16:44:05 Alex Riesen wrote:
>> I think something like this should make the accident more
>> noticable:
>
> Doesn't actually tell what the problem might be, though.
>
Oh, sorry. Somehow I thought, you did found what the problem is
(Git is not an archiving tool and does not store irregular files), and
just wanted to point at "git add" failing silently adding such a name.
In this particular case, the name you given to Git, is a device
entry point, which is filtered. Far too early, in my opinion, so
no sensible diagnostics can be produced. That's why I suggested
an exit with generic error message. I hope it is enough to at least
point the user to where a problem (like a fifo, device or socket
give in the command line) might be.
next prev parent reply other threads:[~2010-04-17 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 14:24 [BUG] Git add <device file> silently fails Andreas Gruenbacher
2010-04-17 14:44 ` Alex Riesen
2010-04-17 15:00 ` Andreas Gruenbacher
2010-04-17 15:27 ` Alex Riesen [this message]
2010-04-17 16:38 ` Junio C Hamano
2010-04-17 17:32 ` Alex Riesen
2010-04-17 18:23 ` Alex Riesen
2010-04-17 17:57 ` Andreas Gruenbacher
2010-04-19 5:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g2h81b0412b1004170827y883c0cc8ofc72712c20e95dc8@mail.gmail.com \
--to=raa.lkml@gmail.com \
--cc=agruen@suse.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).