From: Nick Edelen <sirnot@gmail.com>
To: Julian Phillips <julian@quantumfyre.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>, Nicolas Pitre <nico@cam.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Sam Vilain <sam@vilain.net>,
Michael J Gruber <git@drmicha.warpmail.net>,
Jeff King <peff@peff.net>,
"Shawn O. Pearce" <spearce@spearce.org>,
Andreas Ericsson <exon@op5.se>,
Christian Couder <christian@couder.net>,
git@vger.kernel.org
Subject: Re: [PATCH 2/7 (v5)] basic api and porcelain
Date: Tue, 6 Apr 2010 23:40:35 +0200 [thread overview]
Message-ID: <g2jc77435a81004061440l47f98094v99930eeb4ae6088@mail.gmail.com> (raw)
In-Reply-To: <dbe35e7547614331d19b811c180731aa@212.159.54.234>
> head.signature is 8 characters (see below), and so is "REVCACHE". Surely
> either
> head.signature needs to be 9 characters, or you shouldn't use strcpy.
> Indeed, mostly you do seem to be using memcpy ...
aw shit, don't know how those slipped in there... managed to do that
with slice pointer initialization too. looks like I might have to do
another submission later.
prev parent reply other threads:[~2010-04-06 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 19:58 [PATCH 2/7 (v5)] basic api and porcelain Nick Edelen
2010-04-06 19:25 ` Julian Phillips
2010-04-06 21:40 ` Nick Edelen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g2jc77435a81004061440l47f98094v99930eeb4ae6088@mail.gmail.com \
--to=sirnot@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=christian@couder.net \
--cc=exon@op5.se \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=julian@quantumfyre.co.uk \
--cc=nico@cam.org \
--cc=peff@peff.net \
--cc=sam@vilain.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).